Skip to content
This repository was archived by the owner on Nov 24, 2025. It is now read-only.

Fix golang tests from moved functions#3936

Merged
rob05c merged 1 commit into
apache:masterfrom
mhoppa:bug/fix_tests
Sep 25, 2019
Merged

Fix golang tests from moved functions#3936
rob05c merged 1 commit into
apache:masterfrom
mhoppa:bug/fix_tests

Conversation

@mhoppa

@mhoppa mhoppa commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

What does this PR (Pull Request) do?

  • This PR is not related to any Issue

Which Traffic Control components are affected by this PR?

Only testing fix change

What is the best way to verify this PR?

Pull and run go test

If this is a bug fix, what versions of Traffic Control are affected?

The following criteria are ALL met by this PR

  • This PR includes tests
  • I have explained why documentation is unnecessary
  • This PR does not include an update to CHANGELOG.md
  • This PR includes any and all required license headers
  • This PR does not include a database migration
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@asf-ci

asf-ci commented Sep 25, 2019

Copy link
Copy Markdown
Contributor

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/4313/
Test PASSed.

@rob05c rob05c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! My fault for missing the move. Tested, both lib/go-atscfg and traffic_ops/traffic_ops_golang unit tests pass.

@rob05c rob05c merged commit f260f0a into apache:master Sep 25, 2019
@mitchell852 mitchell852 added Traffic Ops related to Traffic Ops tests related to tests and/or testing infrastructure labels Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tests related to tests and/or testing infrastructure Traffic Ops related to Traffic Ops

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants