Permalink
Browse files

TS-1223: fix the crash in http_ui show network connections

  The problem here is a mess up in the using of va_list, aap
  is saved for later checking, and va_scratch is for printf.

  Thanks to Weijin for the carefully review.
  • Loading branch information...
1 parent 04259ec commit e827aab3ca5d1f081d68275f8de28ae8072a06df Chen Bin committed with mingzym Oct 23, 2012
Showing with 3 additions and 1 deletion.
  1. +2 −0 CHANGES
  2. +1 −1 proxy/Show.h
View
@@ -1,6 +1,8 @@
-*- coding: utf-8 -*-
Changes with Apache Traffic Server 3.3.1
+ *) [TS-1223] fix the crash in http_ui show network connections
+
*) [TS-1543] Enable non-debug logging for rfc5861 plugin
*) [TS-1512] get volume & hosting work with cluster
View
@@ -50,7 +50,7 @@ struct ShowCont: public Continuation
int l = ebuf - buf;
va_start(aap, s);
va_copy(va_scratch, aap);
- int done = vsnprintf(buf, l, s, aap);
+ int done = vsnprintf(buf, l, s, va_scratch);
va_end(va_scratch);
if (done > l - 256)
{

0 comments on commit e827aab

Please sign in to comment.