New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS-4967: Enable header_freq logging to a specific file. #1107

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
4 participants
@SolidWallOfCode
Member

SolidWallOfCode commented Oct 13, 2016

No description provided.

@atsci

This comment has been minimized.

Show comment
Hide comment
@atsci

atsci commented Oct 13, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1005/ for details.

@atsci

This comment has been minimized.

Show comment
Hide comment
@atsci

atsci commented Oct 13, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/897/ for details.

@jpeach

jpeach approved these changes Oct 13, 2016

This looks fine.

I'd be inclined to use a TSTextLogObject rather that stdout, but it probably doesn't matter much for this purpose.

Show outdated Hide outdated plugins/experimental/header_freq/header_freq.cc Outdated
@SolidWallOfCode

This comment has been minimized.

Show comment
Hide comment
@SolidWallOfCode

SolidWallOfCode Oct 13, 2016

Member

Well, beyond that TSTextLogObjectCreate doesn't seem to be documented, it seems more work than is useful for a single write. Note that there's no guarantee multiple invocations will all use the same file.

Member

SolidWallOfCode commented Oct 13, 2016

Well, beyond that TSTextLogObjectCreate doesn't seem to be documented, it seems more work than is useful for a single write. Note that there's no guarantee multiple invocations will all use the same file.

@atsci

This comment has been minimized.

Show comment
Hide comment
@atsci

atsci commented Oct 13, 2016

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1006/ for details.

@atsci

This comment has been minimized.

Show comment
Hide comment
@atsci

atsci commented Oct 13, 2016

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/898/ for details.

@SolidWallOfCode

This comment has been minimized.

Show comment
Hide comment
@SolidWallOfCode

SolidWallOfCode Oct 14, 2016

Member

I communicated with Petar about this as well and he's fine with it.

Member

SolidWallOfCode commented Oct 14, 2016

I communicated with Petar about this as well and he's fine with it.

@SolidWallOfCode SolidWallOfCode merged commit e46d64f into apache:master Oct 14, 2016

@zwoop zwoop added the Plugins label Oct 18, 2016

@zwoop zwoop added this to the 7.1.0 milestone Oct 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment