From f3752812588ec82a28cdd37c9afa0dd7279314cb Mon Sep 17 00:00:00 2001 From: Masaori Koshiba Date: Thu, 16 Apr 2026 10:22:26 +0900 Subject: [PATCH 1/3] Cleanup set_connect_fail debug log --- include/proxy/http/HttpTransact.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/proxy/http/HttpTransact.h b/include/proxy/http/HttpTransact.h index 33f4eafe897..0ee70c1d68b 100644 --- a/include/proxy/http/HttpTransact.h +++ b/include/proxy/http/HttpTransact.h @@ -953,7 +953,13 @@ class HttpTransact if (e != EIO) { this->cause_of_death_errno = e; } - Dbg(_dbg_ctl, "Setting upstream connection failure %d to %d", original_connect_result, this->current.server->connect_result); + + if (_dbg_ctl.on()) { + std::string buf; + swoc::bwprint(buf, "Setting connect_result {::s} to {::s}", swoc::bwf::Errno(e), swoc::bwf::Errno(original_connect_result), + swoc::bwf::Errno(this->current.server->connect_result)); + Dbg(_dbg_ctl, "%s", buf.c_str()); + } } MgmtInt From 7f7d63d042ed6e98e7cdbfc35f38f1e871a5e4e4 Mon Sep 17 00:00:00 2001 From: Masaori Koshiba Date: Tue, 21 Apr 2026 10:55:55 +0900 Subject: [PATCH 2/3] Fix args --- include/proxy/http/HttpTransact.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/proxy/http/HttpTransact.h b/include/proxy/http/HttpTransact.h index 0ee70c1d68b..5645755f696 100644 --- a/include/proxy/http/HttpTransact.h +++ b/include/proxy/http/HttpTransact.h @@ -956,7 +956,7 @@ class HttpTransact if (_dbg_ctl.on()) { std::string buf; - swoc::bwprint(buf, "Setting connect_result {::s} to {::s}", swoc::bwf::Errno(e), swoc::bwf::Errno(original_connect_result), + swoc::bwprint(buf, "Setting connect_result {::s} to {::s}", swoc::bwf::Errno(original_connect_result), swoc::bwf::Errno(this->current.server->connect_result)); Dbg(_dbg_ctl, "%s", buf.c_str()); } From d299b4b0b2507d546b3115197912a894a5920d22 Mon Sep 17 00:00:00 2001 From: Masaori Koshiba Date: Tue, 21 Apr 2026 11:00:28 +0900 Subject: [PATCH 3/3] Include swoc header explicitly --- include/proxy/http/HttpTransact.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/proxy/http/HttpTransact.h b/include/proxy/http/HttpTransact.h index 5645755f696..a6d48a12f7f 100644 --- a/include/proxy/http/HttpTransact.h +++ b/include/proxy/http/HttpTransact.h @@ -47,6 +47,8 @@ #include "proxy/ProxySession.h" #include "tscore/MgmtDefs.h" +#include "swoc/bwf_ex.h" + #include #include #include