Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 400 if there is whitespace after the field name and before the colon #3192

Merged
merged 1 commit into from Feb 28, 2018

Conversation

Projects
None yet
2 participants
@bryancall
Copy link
Contributor

commented Feb 27, 2018

colon

@bryancall bryancall added the HTTP label Feb 27, 2018

@bryancall bryancall added this to the 8.0.0 milestone Feb 27, 2018

@bryancall bryancall self-assigned this Feb 27, 2018

@bryancall bryancall force-pushed the bryancall:field_name_whitespace branch from f2ccd84 to 2eb04a7 Feb 28, 2018

@bryancall bryancall requested a review from zwoop Feb 28, 2018

@@ -496,7 +496,7 @@ HdrTest::test_mime()
"continuation: part1\r\n"
" part2\r\n"
"scooby: doo\r\n"
"scooby : doo\r\n"

This comment has been minimized.

Copy link
@zwoop

zwoop Feb 28, 2018

Contributor

I think there's a way to have headers that should fail the parsing too, right? Maybe move the failure one there?

@zwoop zwoop added this to 7.1.3 backport in 7.x releases Feb 28, 2018

@zwoop

zwoop approved these changes Feb 28, 2018

@bryancall bryancall merged commit 08512de into apache:master Feb 28, 2018

8 checks passed

Jenkins CentOS Build finished.
Details
Jenkins Clang-Analyzer Build finished.
Details
Jenkins FreeBSD Build finished.
Details
Jenkins ICC Build finished.
Details
Jenkins RAT Build finished.
Details
Jenkins Ubuntu Build finished.
Details
Jenkins autest Build finished.
Details
Jenkins clang-format Build finished.
Details
@zwoop

This comment has been minimized.

Copy link
Contributor

commented Feb 28, 2018

Cherry-picked to 7.1.x

@zwoop zwoop removed this from 7.1.3 backport in 7.x releases Feb 28, 2018

@zwoop zwoop modified the milestones: 8.0.0, 7.1.3 Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.