Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drain the request body if there is a cache hit #3251

Merged
merged 1 commit into from Mar 9, 2018
Merged

Conversation

@bryancall
Copy link
Contributor

@bryancall bryancall commented Mar 8, 2018

Only drain if the request body has a Content-Length and all the bytes are in the buffer.
Otherwise, close the connection after the response.

@bryancall bryancall added the HTTP label Mar 8, 2018
@bryancall bryancall added this to the 8.0.0 milestone Mar 8, 2018
@bryancall bryancall self-assigned this Mar 8, 2018
@zwoop zwoop added this to 7.1.3 backport in 7.x releases Mar 8, 2018
request body has a Content-Length and all the bytes are in the buffer.
Otherwise, close the connection after the response.
zwoop
zwoop approved these changes Mar 9, 2018
@bryancall
Copy link
Contributor Author

@bryancall bryancall commented Mar 9, 2018

[approve ci autest]

Loading

@zwoop zwoop merged commit c4e4379 into apache:master Mar 9, 2018
9 checks passed
Loading
@zwoop zwoop removed this from 7.1.3 backport in 7.x releases Mar 9, 2018
@zwoop zwoop removed this from the 8.0.0 milestone Mar 9, 2018
@zwoop zwoop added this to the 7.1.3 milestone Mar 9, 2018
@zwoop zwoop removed this from the 7.1.3 milestone Mar 9, 2018
@zwoop zwoop added this to the 8.0.0 milestone Mar 9, 2018
@zwoop
Copy link
Contributor

@zwoop zwoop commented Mar 9, 2018

@bryancall This doesn't cherry-pick nicely to 7.1.x, can you make a separate PR for that back port?

Loading

@zwoop zwoop added this to 7.1.3 backport in 7.x releases Mar 12, 2018
@zwoop zwoop removed this from 7.1.3 backport in 7.x releases Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants