New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEBP] Transform images when a client accepts image/webp. #4616

Merged
merged 1 commit into from Nov 17, 2018

Conversation

Projects
None yet
3 participants
@calavera
Contributor

calavera commented Nov 16, 2018

More browsers besides Chrome have started to support webp
as image format. To advertise their support, they include
image/webp content type in the Accept header.

This change allows this plugin to detect support for webp
by checking the Accept header and keeps the old User-Agent
check for old versions of Chrome.

Signed-off-by: David Calavera david.calavera@gmail.com

@shukitchan

This comment has been minimized.

Contributor

shukitchan commented Nov 16, 2018

[approve ci]

Transform images when a client accepts image/webp.
More browsers besides Chrome have started to support webp
as image format. To advertise their support, they include
image/webp content type in the Accept header.

This change allows this plugin to detect support for webp
by checking the Accept header and keeps the old User-Agent
check for old versions of Chrome.

Signed-off-by: David Calavera <david.calavera@gmail.com>

@calavera calavera force-pushed the calavera:webp_accept_header branch from ca74e6d to 0be9344 Nov 16, 2018

@calavera

This comment has been minimized.

Contributor

calavera commented Nov 16, 2018

I've updated the code to fix the clang formatting.

@randall

This comment has been minimized.

Contributor

randall commented Nov 16, 2018

[approve ci]

@randall randall added this to the 9.0.0 milestone Nov 16, 2018

@randall randall added the Plugins label Nov 16, 2018

@shukitchan

It looks good. Thanks.

@shukitchan shukitchan merged commit 65e7b75 into apache:master Nov 17, 2018

9 checks passed

Jenkins CentOS Build finished.
Details
Jenkins Clang-Analyzer Build finished.
Details
Jenkins Debian Build finished.
Details
Jenkins FreeBSD Build finished.
Details
Jenkins ICC Build finished.
Details
Jenkins RAT Build finished.
Details
Jenkins Ubuntu Build finished.
Details
Jenkins autest Build finished.
Details
Jenkins clang-format Build finished.
Details

@calavera calavera deleted the calavera:webp_accept_header branch Nov 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment