This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
[TRAFODION-2821] Trafodion core code base needs to be thread safe #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java exceptions thrown while calling the java methods from JNI in Trafodion are stored in the current context. However in a multi-threaded ESP environment, these exceptions should be stored in thread specific variable to enable error handling to be thread safe. Otherwise, the JNI errors could be overwritten by the JNI errors from another thread. Also streamlined JNI error handling by extending the getExceptionDetails() methods to log the errors also. Incorporated error handling in SequenceFileReader JNI methods.
|
Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2511/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2511/ |
|
@robertamarton Can you please review this change |
|
+1 |
| getExceptionDetails(); | ||
| logError(CAT_SQL_HBASE, __FILE__, __LINE__); | ||
| logError(CAT_SQL_HBASE, "HBaseClient_JNI::releaseHTableClient()", getLastError()); | ||
| jenv_->PopLocalFrame(NULL); |
There was a problem hiding this comment.
Did you mean to delete the jenv_->PopLocalFrame call here?
There was a problem hiding this comment.
Yes. I will add it back in my next check-in
Fixes as per review comments and missed out changes in the commit 073cf68
|
New Check Test Started: https://jenkins.esgyn.com/job/Check-PR-master/2519/ |
|
Test Passed. https://jenkins.esgyn.com/job/Check-PR-master/2519/ |
|
+1. Looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java exceptions thrown while calling the java methods from JNI in
Trafodion are stored in the current context. However in a multi-threaded
ESP environment, these exceptions should be stored in thread specific
variable to enable error handling to be thread safe. Otherwise, the JNI
errors could be overwritten by the JNI errors from another thread.
Also streamlined JNI error handling by extending the getExceptionDetails()
method to log the errors also.
Incorporated error handling in SequenceFileReader JNI methods.