Skip to content

[To dev/1.1] perf: Optimize aligned object memory size calculation (#577) #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2025
Merged

[To dev/1.1] perf: Optimize aligned object memory size calculation (#577) #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions java/common/src/main/java/org/apache/tsfile/utils/RamUsageEstimator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,8 @@ private RamUsageEstimator() {}
*/
public static final int NUM_BYTES_OBJECT_ALIGNMENT;

private static final int ALIGN_MASK;

/**
* Approximate memory usage that we assign to all unknown queries - this maps roughly to a
* BooleanQuery with a couple term clauses.
Expand Down Expand Up @@ -180,6 +182,8 @@ private RamUsageEstimator() {}
NUM_BYTES_ARRAY_HEADER = NUM_BYTES_OBJECT_HEADER + Integer.BYTES;
}

ALIGN_MASK = NUM_BYTES_OBJECT_ALIGNMENT - 1;

// get min/max value of cached Long class instances:
long longCacheMinValue = 0;
while (longCacheMinValue > Long.MIN_VALUE
Expand Down Expand Up @@ -209,8 +213,7 @@ private RamUsageEstimator() {}

/** Aligns an object size to be the next multiple of {@link #NUM_BYTES_OBJECT_ALIGNMENT}. */
public static long alignObjectSize(long size) {
size += NUM_BYTES_OBJECT_ALIGNMENT - 1L;
return size - (size % NUM_BYTES_OBJECT_ALIGNMENT);
return (size + ALIGN_MASK) & ~ALIGN_MASK;
}

/**
Expand Down
Loading