Remove javah support #10104
Merged
Remove javah support #10104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argrento
requested review from
comaniac,
icemelon,
jroesch,
junrushao,
tqchen,
yzhliu and
zhiics
as code owners
|
LGTM |
elvin-n
approved these changes
Jan 31, 2022
|
Did you check if it works on MacOS? I'm not sure but it might be necessary to modify also this file: https://github.com/apache/tvm/blob/main/jvm/native/osx-x86_64/pom.xml |
jwfromm
approved these changes
Feb 3, 2022
mbs-octoml
pushed a commit
to mbs-octoml/mbs-tvm
that referenced
this pull request
Feb 5, 2022
* Remove javah support * Remove unused compiler option * Osx pom.xml update
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Remove javah support * Remove unused compiler option * Osx pom.xml update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow https://openjdk.java.net/jeps/313 and remove 'javah' from scripts and configs for linux platform and some android apps.