Skip to content

[Hexagon] Minor changes/fixes in codegen_hexagon.cc#12308

Merged
mehrdadh merged 1 commit into
apache:mainfrom
kparzysz-quic:codegen-hexagon
Aug 9, 2022
Merged

[Hexagon] Minor changes/fixes in codegen_hexagon.cc#12308
mehrdadh merged 1 commit into
apache:mainfrom
kparzysz-quic:codegen-hexagon

Conversation

@kparzysz-quic
Copy link
Copy Markdown
Contributor

@kparzysz-quic kparzysz-quic commented Aug 4, 2022

  1. Change calls to inherited functions to use CodeGenCPU:: instead of CodeGenLLVM::.
  2. Fix #if guards for #includes.
  3. Remove InitContextPtr and GetContextPtr, use the ones from CodeGenCPU.

cc @mehrdadh

1. Change calls to inherited functions to use CodeGenCPU:: instead of
   CodeGenLLVM::.
2. Fix #if guards for #include's.
3. Remove InitContextPtr and GetContextPtr, use the ones from CodeGenCPU.
@github-actions github-actions Bot requested a review from mehrdadh August 4, 2022 19:30
@mehrdadh
Copy link
Copy Markdown
Member

mehrdadh commented Aug 5, 2022

@kparzysz-quic I still see few instances of using CodeGenLLVM in hexagon codegen. Are they intentional?

@kparzysz-quic
Copy link
Copy Markdown
Contributor Author

The ones in CodeGenLLVM::TypedPointer? Yes, those are left on purpose. That type is defined in CodeGenLLVM, and cannot be overridden. The intent was to indicate where in the class hierarchu the type was defined.

@mehrdadh mehrdadh merged commit 23b203e into apache:main Aug 9, 2022
@kparzysz-quic kparzysz-quic deleted the codegen-hexagon branch August 12, 2022 19:48
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
1. Change calls to inherited functions to use CodeGenCPU:: instead of
   CodeGenLLVM::.
2. Fix #if guards for #include's.
3. Remove InitContextPtr and GetContextPtr, use the ones from CodeGenCPU.
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
1. Change calls to inherited functions to use CodeGenCPU:: instead of
   CodeGenLLVM::.
2. Fix #if guards for #include's.
3. Remove InitContextPtr and GetContextPtr, use the ones from CodeGenCPU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants