[Relax][Frontend][TFLite] Add tests coverage for SPACE_TO_BATCH_ND and BATCH_TO_SPACE_ND#19499
Merged
Conversation
…d BATCH_TO_SPACE_ND
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TFLite frontend to implement batch_to_space_nd and space_to_batch_nd using call_dps_packed with TOPI functions, and adds unit tests for these operations. Feedback includes a correction for an incorrect argument count in the batch_to_space_nd call and a recommendation to use to_int_list for shape and padding parameters to ensure type safety within the Relax IR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add tests in
test_frontend_tflite.py.Lower S
PACE_TO_BATCH_ND/BATCH_TO_SPACE_NDthrough TOPI intflite_frontend.py.Use tf.raw_ops.BatchToSpaceND in the test because tf.batch_to_space_nd is not available in this TF build.
Why the TFLite frontend changed
The frontend was calling relax.op.nn.space_to_batch_nd / relax.op.nn.batch_to_space_nd, which aren’t implemented in this checkout. I updated the TFLite frontend to lower these ops via TOPI packed calls so conversion works and the new tests can pass.
Test:
related to #18971