[TVMScript] Handle undefined functions when dumping IRModule#19583
Merged
Conversation
PrimFuncPass temporarily clears the module slot for the function being transformed before calling pass_func. Dumping the IRModule mid-pass can therefore see undefined BaseFuncs and crash in SortableFunction when calling tvm::Dump(). Guard with func.defined(), assign a fallback sort priority, and log instead of dereferencing.
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SortableFunction constructor in src/script/printer/ir/ir.cc to handle undefined functions, assigning them a specific priority and logging an info message to prevent crashes during debugging. The reviewer identified that the current implementation inconsistently handles the main function when it is undefined and noted that a crash could still occur later in the printing loop. A refactoring was suggested to check for undefined functions first and ensure consistent logging and priority assignment.
tlopex
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PrimFuncPass temporarily clears the module slot for the function being transformed before calling pass_func. Dumping the IRModule mid-pass can therefore see undefined BaseFuncs and crash in SortableFunction when calling tvm::Dump(). Guard with func.defined(), assign a fallback sort priority, and log instead of dereferencing.