This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-227) Disabling caching of FileSystem instance when getting delegation token #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #45 due to accidentally deleting the branch. |
…egation token - Allows getting delegation token for different users without leaking memory. - The FileSystem.get() by default will cache all FileSystem instances until end of process.
chtyim
force-pushed
the
feature/TWILL-227
branch
from
b2ce61f
to
12f0b70
Compare
anew
reviewed
Mar 28, 2017
| } | ||
| try (FileSystem fileSystem = getFileSystem(locationFactory)) { | ||
| if (fileSystem == null) { | ||
| LOG.warn("Unexpected: LocationFactory is not backed by FileContextLocationFactory"); |
There was a problem hiding this comment.
seems that this message should be logged inside getFileSystem()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.