This repository has been archived by the owner on May 12, 2021. It is now read-only.
(TWILL-179) Added support for custom ClassLoader for containers #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chtyim
commented
Apr 3, 2017
chtyim
commented
- Added method TwillPreparer.setClassLoader
- Use system property "twill.custom.class.loader" to pass the class name of the custom ClassLoader
- Added method TwillPreparer.setClassLoader - Use system property "twill.custom.class.loader" to pass the class name of the custom ClassLoader
anwar6953
reviewed
Apr 3, 2017
| // | ||
| // public class Generated { | ||
| // | ||
| // public void announce(ServiceAnnouncer announcer, String serviceName, int port) { |
There was a problem hiding this comment.
Is the javadoc outdated/inconsistent?
Cancellable is declared as the return type, below on line 76.
There was a problem hiding this comment.
actually the comment is correct. The generated method has void return type. The announcer.announce method has Cancellable return type, but the result gets ignored (hence the mg.pop() code in line 79).
|
1 minor comment; remainder LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.