FOP-3322: Fix/pdfua internal link contents#102
Open
mgr34 wants to merge 2 commits into
Open
Conversation
PDF/UA-1 (ISO 14289-1 §7.18.5) requires every link annotation to carry an alternate description in its /Contents key. FOP set this only for external (URI) links, where the alt text travels with the PDFUri action. Internal (GoTo) links got /Alt on the Link structure element but no /Contents on the annotation, so each one failed validation. PDFDocumentNavigationHandler.renderLink now reads the alternate text back from the Link structure element's /Alt (which already holds fox:alt-text) and sets it on the PDFLink for both link types. PDFLink.toPDFString emits /Contents from this explicit value when present, otherwise falling back to the URI action's alt text as before. Adds PDFLinkContentsTestCase covering internal links with and without an alternate description, the external-link fallback, and explicit precedence.
mgr34
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves FOP-3322 [0]. By setting the alt description written to the
/Contentsentry of the link annotation dict. PDF/UA-1 requires every link annotation to carry an alternate description.Can verify result by running against the assets in FOP-3322.
Note
verapdfis a product of the Open source industry supported PDF/A validation maintained by the Open Preservation Foundation [1][0] https://issues.apache.org/jira/browse/FOP-3322
[1] https://github.com/verapdf
[2] https://pdfa.org/resource/iso-14289-pdfua/