Skip to content

Commit

Permalink
[ZEPPELIN-4333] escape dialog title and message
Browse files Browse the repository at this point in the history
### What is this PR for?
There're couple of places in the code that dialog title and message is not being escaped

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4333

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #3449 from Leemoonsoo/ZEPPELIN-4333 and squashes the following commits:

82dab12 [Lee moon soo] escape dialog title and message
  • Loading branch information
Leemoonsoo committed Sep 19, 2019
1 parent f9e2ff8 commit a7cf49c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion zeppelin-web/src/app/helium/helium.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ export default function HeliumCtrl($scope, $rootScope, $sce,
confirm.close();
console.log('Failed to install an interpreter %o %o', name, artifact);
BootstrapDialog.show({
title: 'Error while starting to install ' + name + ' interpreter',
title: 'Error while starting to install ' + _.escape(name) + ' interpreter',
message: _.escape(data.message),
});
});
Expand Down

0 comments on commit a7cf49c

Please sign in to comment.