New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add force layout visualization in paragraphs for SQL queries #1135
Conversation
@AhyoungRyu I did exactly as you told me, and all of the other commits were added to my PR. I undid the push and went back to the original commit of the pull request. Can you please advise? thanks |
@davidtzoor Oh sorry for my late response. Did you fetch the latest version of upstream
Then check
then try to fix the conflict. |
You might also need |
@corneadoug are the build errors due to my code? |
@davidtzoor No the CI is fine |
@corneadoug so is my PR ok? |
hi @corneadoug any update on this PR? I am sorry to poke you it. Just wanted to know if there something else I need to do. Thanks 👍 |
@davidtzoor sorry for the long wait, I was trying to finish a few things before looking closer into this PR. There was another visualization that got merged, so you will have to rebase. Can you also provide a few things to make it easier for me to review:
Then I should be able to test it out, and give some feedback to have it merged |
@corneadoug great! I will get it done by end of day and update you. |
@davidtzoor Take your time, just ping me when its done |
@corneadoug I have rebased, added the test data, instructions and data model above. Please let me know what you think |
@corneadoug any update on my PR? looking forward to your feedback |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
Add force layout (graph) visualization to the existing set of visualizations in Zeppelin Web notp.
What type of PR is it?
[Feature]
PR description
data model used by the graph:
node.name
is the unique identifier of a node, thegroup
determines the color of the node.link.source/target
are the start and end points of the edges of the graph, based on thenodes
names.What is the Jira issue?
[ZEPPELIN-1011]
How should this be tested?
Run the following 2 code samples in a paragraph to generate the data set in the context:
now run the following to get the data set:
%sql select * from example
and finally choose the source and destination columns to generate the graph:
Screenshot
Questions:
No.
No.
We can add some documentation explaining about the different fields that need to be selected in order to generate the force layout component.