Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonted download chinese garbled fix #1151

Closed

Conversation

@cquptEthan
Copy link
Contributor

cquptEthan commented Jul 8, 2016

What is this PR for?

Fix chinese garbled open with Excel #714

What type of PR is it?

Bug Fix

Todos

  • - Add Bom Header

What is the Jira issue?

ZEPPELIN-672

How should this be tested?

create a paragraph with chinses chars data in %table view.
download with CSV format and open with Excel.

Questions:

  • Does the licenses files need update?
    No
  • Is there breaking changes for older versions?
    No
  • Does this needs documentation?
    No
cquptEthan added 2 commits Jul 8, 2016
add bom header in  front-end download file
@cquptEthan cquptEthan changed the title Fonted download error code fix Fonted download chinese garbled fix Jul 8, 2016
@Leemoonsoo

This comment has been minimized.

Copy link
Member

Leemoonsoo commented Jul 8, 2016

Tested and confirmed it fixes the problem.

@cquptEthan thanks for the contribution.
Do you mind create a jira issue for it?
Then I'd like to mark fix version 0.6.1 and merge it into master, branch-0.6.

@cquptEthan

This comment has been minimized.

Copy link
Contributor Author

cquptEthan commented Jul 8, 2016

@Leemoonsoo Thanks.
I've created ZEPPELIN-1138 for it

@Leemoonsoo

This comment has been minimized.

Copy link
Member

Leemoonsoo commented Jul 8, 2016

Thanks @cquptEthan. I'm merging it into master and branch-0.6 if there is no more discussion.

@cquptEthan

This comment has been minimized.

Copy link
Contributor Author

cquptEthan commented Jul 8, 2016

@asfgit asfgit closed this in 513b8ab Jul 11, 2016
asfgit pushed a commit that referenced this pull request Jul 11, 2016
### What is this PR for?
Fix chinese garbled open with Excel #714

### What type of PR is it?
Bug Fix

### Todos
* [x] - Add Bom Header

### What is the Jira issue?
[ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672)

### How should this be tested?
create a paragraph with chinses chars data in %table view.
download with CSV format and open with Excel.

### Questions:
* Does the licenses files need update?
 No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No

Author: ZhangEthan <228477911@qq.com>

Closes #1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits:

a4a99b4 [ZhangEthan] Fix  chinese garbled in Excel
46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix

(cherry picked from commit 513b8ab)
Signed-off-by: Lee moon soo <moon@apache.org>
@Leemoonsoo Leemoonsoo mentioned this pull request Jul 11, 2016
1 of 1 task complete
asfgit pushed a commit that referenced this pull request Jul 11, 2016
### What is this PR for?
#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.

```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build)  zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix problem

### What is the Jira issue?
ZEPPELIN-1138,  ZEPPELIN-235

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1165 from Leemoonsoo/fix_js and squashes the following commits:

3819ffb [Lee moon soo] add space

(cherry picked from commit 0590ef3)
Signed-off-by: Lee moon soo <moon@apache.org>
asfgit pushed a commit that referenced this pull request Jul 11, 2016
### What is this PR for?
#1151 has been created created before #1139 merge.
#1151 was passing CI but it's failing in master with #1139 merged.

```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build)  zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix problem

### What is the Jira issue?
ZEPPELIN-1138,  ZEPPELIN-235

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes #1165 from Leemoonsoo/fix_js and squashes the following commits:

3819ffb [Lee moon soo] add space
@cquptEthan cquptEthan deleted the cquptEthan:fonted-download-error-code-fix branch Jul 12, 2016
PhilippGrulich added a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
Fix chinese garbled open with Excel apache#714

### What type of PR is it?
Bug Fix

### Todos
* [x] - Add Bom Header

### What is the Jira issue?
[ZEPPELIN-672](https://issues.apache.org/jira/browse/ZEPPELIN-672)

### How should this be tested?
create a paragraph with chinses chars data in %table view.
download with CSV format and open with Excel.

### Questions:
* Does the licenses files need update?
 No
* Is there breaking changes for older versions?
No
* Does this needs documentation?
No

Author: ZhangEthan <228477911@qq.com>

Closes apache#1151 from cquptEthan/fonted-download-error-code-fix and squashes the following commits:

a4a99b4 [ZhangEthan] Fix  chinese garbled in Excel
46628c2 [ZhangEthan] Merge branch 'apache/master' into fonted-download-error-code-fix
PhilippGrulich added a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
apache#1151 has been created created before apache#1139 merge.
apache#1151 was passing CI but it's failing in master with apache#1139 merged.

```
[INFO] --- frontend-maven-plugin:0.0.25:grunt (grunt build)  zeppelin-web ---
[INFO] Running 'grunt build --no-color' in /Users/moon/Projects/zeppelin/zeppelin-web
[INFO] Running "jscs:all" (jscs) task
[INFO] requireSpaceBeforeBinaryOperators: Operator = should not stick to preceding expression at src/components/saveAs/saveAs.service.js :
[INFO]     21 |      angular.element('body').append('<iframe id="SaveAsId" style="display: none"></iframe>');
[INFO]     22 |      var frameSaveAs = angular.element('body > iframe#SaveAsId')[0].contentWindow;
[INFO]     23 |      content= BOM + content;
[INFO] ---------------------^
[INFO]     24 |      frameSaveAs.document.open('text/json', 'replace');
[INFO]     25 |      frameSaveAs.document.write(content);
[INFO] >> 1 code style errors found!
[INFO] Warning: Task "jscs:all" failed. Use --force to continue.
[INFO]
[INFO] Aborted due to warnings.
```

### What type of PR is it?
Hot Fix

### Todos
* [x] - Fix problem

### What is the Jira issue?
ZEPPELIN-1138,  ZEPPELIN-235

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Lee moon soo <moon@apache.org>

Closes apache#1165 from Leemoonsoo/fix_js and squashes the following commits:

3819ffb [Lee moon soo] add space
@ebuildy

This comment has been minimized.

Copy link
Contributor

ebuildy commented Jul 26, 2017

Hello, the Jira issue is still opened https://issues.apache.org/jira/browse/ZEPPELIN-1137 ?

@1ambda

This comment has been minimized.

Copy link
Member

1ambda commented Aug 16, 2017

Closed. Thanks for the reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.