Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Remove spaces between intepreter group and name #1448

Closed
wants to merge 1 commit into from

Conversation

minahlee
Copy link
Member

What is this PR for?

#1395 changed alignment of html tag and it caused to make space between interpreter group and name.

What type of PR is it?

Bug Fix

Screenshots (if appropriate)

Before
screen shot 2016-09-22 at 11 31 35 am

After
screen shot 2016-09-22 at 11 32 02 am

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Contributor

@minahlee Nice catch! LGTM 👍

@zjffdu
Copy link
Contributor

zjffdu commented Sep 23, 2016

LGTM

1 similar comment
@astroshim
Copy link
Contributor

LGTM

@minahlee
Copy link
Member Author

Merging it into master

@asfgit asfgit closed this in 3021d46 Sep 25, 2016
@minahlee minahlee deleted the showInterpreterList branch October 7, 2016 07:15
pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
apache#1395 changed alignment of html tag and it caused to make space between interpreter group and name.

### What type of PR is it?
Bug Fix

### Screenshots (if appropriate)
**Before**
<img width="436" alt="screen shot 2016-09-22 at 11 31 35 am" src="https://cloud.githubusercontent.com/assets/8503346/18743269/7fa34b16-80b8-11e6-979a-194e7f6bef8f.png">

**After**
<img width="411" alt="screen shot 2016-09-22 at 11 32 02 am" src="https://cloud.githubusercontent.com/assets/8503346/18743271/83807038-80b8-11e6-80b1-775c3369940e.png">

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Mina Lee <minalee@apache.org>

Closes apache#1448 from minahlee/showInterpreterList and squashes the following commits:

5e2315a [Mina Lee] Remove space in available interpreters list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants