Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Change Markdown class name from MarkdownInterpreter to Markdown #1449

Closed
wants to merge 1 commit into from

Conversation

minahlee
Copy link
Member

@minahlee minahlee commented Sep 22, 2016

What is this PR for?

Markdown interpreter's class name have changed from Markdown to MarkdownInterpreter in #1384 and this will bring some compatibility issue in case user have Markdown class specified in conf/interpreter.json file. This PR rollbacks markdown class name from MarkdownInterpreter to Markdown to avoid side effect

What type of PR is it?

Hotfix

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@prabhjyotsingh
Copy link
Contributor

LGTM 👍

@minahlee minahlee force-pushed the update/markdownClassName branch 2 times, most recently from 08430a3 to fb7d5e7 Compare September 22, 2016 15:03
@AhyoungRyu
Copy link
Contributor

LGTM 👍 👍

@Leemoonsoo
Copy link
Member

In case users who already have conf/interpreter.json upgrades Zeppelin, the file includes old classname. for example

  "interpreterSettings": {
    "2BUVF72FJ": {
      "id": "2BUVF72FJ",
      "name": "md",
      "group": "md",
      "interpreterGroup": [
        {
          "name": "md",
          "class": "org.apache.zeppelin.markdown.Markdown",
          "defaultInterpreter": false
        }
      ],

Will there be any problem because of classname change in this case?
Should we change MarkdownInterpreter to Markdown? or Markdown to MarkdownInterpreter?

What do you think?

@minahlee minahlee changed the title [MINOR][DOC] Change Markdown class name from Markdown to MarkdownInterpreter [MINOR] Change Markdown class name from Markdown to MarkdownInterpreter Sep 23, 2016
@minahlee
Copy link
Member Author

@Leemoonsoo Thank you for pointing it out. I think changing the class name to Markdown is more proper way to avoid compatibility issue.

@minahlee minahlee changed the title [MINOR] Change Markdown class name from Markdown to MarkdownInterpreter [MINOR] Change Markdown class name from MarkdownInterpreter to Markdown Sep 23, 2016
@minahlee
Copy link
Member Author

Merging if there is no more discussion

@asfgit asfgit closed this in 46ecf77 Sep 28, 2016
@minahlee minahlee deleted the update/markdownClassName branch October 7, 2016 07:15
@kavinkumarks
Copy link
Contributor

I am facing issues in my local on running paragraph with md interpreter since the markdown class name is 'MarkdownInterpreter' in conf/interpreter.json What should I do to resolve this without deleting the interpreter.json file?

Thanks,
Kavin
MailTo: kavin.kumar@imaginea.com

@Leemoonsoo
Copy link
Member

@kavinkumarks I think you can stop Zeppelin and replace all "org.apache.zeppelin.markdown.MarkdownInterpreter" to "org.apache.zeppelin.markdown.Markdown" in conf/interpreter.json, and then start Zeppelin.

@kavinkumarks
Copy link
Contributor

@Leemoonsoo Yeah, it worked by changing it manually.I thought that it should have been taken care auto* when someone changes the relevant class name in the appropriate interpreter-setting.json What do you say?

Thanks,
Kavin
MailTo: kavin.kumar@imaginea.com

@Leemoonsoo
Copy link
Member

@kavinkumarks Yep. class name shouldn't be changed. 'MarkdownInterpreter' to 'Markdown' name change didn't happened across different versions of release. Otherwise, yes, will be taken care automatically.

@kavinkumarks
Copy link
Contributor

kavinkumarks commented Oct 20, 2016

Thanks @Leemoonsoo !

-Kavin

pedrozatta pushed a commit to pedrozatta/zeppelin that referenced this pull request Oct 27, 2016
### What is this PR for?
Markdown interpreter's class name have changed from `Markdown` to `MarkdownInterpreter` in apache#1384 and this will bring some compatibility issue in case user have `Markdown` class specified in `conf/interpreter.json` file. This PR rollbacks markdown class name from `MarkdownInterpreter` to `Markdown` to avoid side effect

### What type of PR is it?
Hotfix

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: Mina Lee <minalee@apache.org>

Closes apache#1449 from minahlee/update/markdownClassName and squashes the following commits:

7bdad44 [Mina Lee] Change classname of MarkdownInterpreter -> Markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants