From ae9820e1f3a536a7f53a8ad18a80e67ff99b6543 Mon Sep 17 00:00:00 2001 From: felizbear Date: Tue, 29 Nov 2016 18:37:02 +0900 Subject: [PATCH] remove usage of non-standard string method use standard `indexOf` method instead of proprietary `contains` defined on string by unknown library; it is a potential bug; also it doesn't add much value at all, compare: stringValue.contains(delimiter) stringValue.indexOf(delimiter) > -1 --- zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js index 6f4dccd7015..c1ad35ef7aa 100644 --- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js +++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js @@ -1338,7 +1338,7 @@ var dsvRow = ''; for (var index in row) { var stringValue = (row[index]).toString(); - if (stringValue.contains(delimiter)) { + if (stringValue.indexOf(delimiter) > -1) { dsvRow += '"' + stringValue + '"' + delimiter; } else { dsvRow += row[index] + delimiter;