Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Refactoring Job and Paragraph #1793

Closed

Conversation

jongyoul
Copy link
Member

@jongyoul jongyoul commented Dec 22, 2016

What is this PR for?

Job class has only two sub classes. I don't think we need Job abstraction class anymore, then I'll move all function of Job into Paragraph and InterpretJob. Paragraph is used into zeppelin-server and InterpretJob is done by remoteInterpreterServer. I think what we disconnect those two different classes is better to maintain each side of codes. This PR moves two variable - result and results - from Job to Paragraph in order to remove Job class. It also based on ZEPPELIN-1594(#1753), thus all reviewers click the last commit and review it.

What type of PR is it?

[Refactoring]

Todos

  • - Moved these variables into Paragraph

What is the Jira issue?

N/A

How should this be tested?

All things are same as before

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jongyoul jongyoul changed the title [MINOR] Refactoring Job and Paragraph [WIP][MINOR] Refactoring Job and Paragraph Dec 22, 2016
@jongyoul
Copy link
Member Author

jongyoul commented Dec 22, 2016

Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 expected:<ABORT> but was:<RUNNING>

This test passed in my local and all others passed.

@jongyoul jongyoul force-pushed the minor/refactoring-job-paragraph branch from 4eff6a6 to 8de238b Compare December 24, 2016 17:36
@jongyoul
Copy link
Member Author

I've rebased after merging #1753

@jongyoul jongyoul changed the title [WIP][MINOR] Refactoring Job and Paragraph [MINOR] Refactoring Job and Paragraph Dec 24, 2016
@jongyoul
Copy link
Member Author

Will merge it.

@asfgit asfgit closed this in 895d921 Dec 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant