Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2215] Progress bar for Spell execution #2105

Closed

Conversation

1ambda
Copy link
Member

@1ambda 1ambda commented Mar 7, 2017

What is this PR for?

Add progress bar for spell execution.

  • Used RUNNING state to display progress bar
  • Decided not to display {number}% for spell, since we can't calculate in advance.

What type of PR is it?

[Improvement]

Todos

NONE

What is the Jira issue?

ZEPPELIN-2215

How should this be tested?

Screenshots (if appropriate)

2215

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda 1ambda closed this Mar 9, 2017
@1ambda 1ambda reopened this Mar 9, 2017
@soralee
Copy link
Contributor

soralee commented Mar 12, 2017

Tested and It's work as described, LGTM

@1ambda
Copy link
Member Author

1ambda commented Mar 13, 2017

@soralee Thanks for review! What do you think about %? Should we keep it for spell?

@AhyoungRyu
Copy link
Contributor

Looks good! Regarding %, if the percentage means nothing, then it's okay with not showing it i think.

@soralee
Copy link
Contributor

soralee commented Mar 15, 2017

@1ambda could you rebase this because of conflicts?

@1ambda 1ambda force-pushed the ZEPPELIN-2215/progress-bar-for-spell branch from 56986c2 to 79e63d4 Compare March 15, 2017 20:19
@1ambda
Copy link
Member Author

1ambda commented Mar 15, 2017

I'v just rebased to resolve conflict.

@1ambda 1ambda closed this Mar 16, 2017
@1ambda 1ambda reopened this Mar 16, 2017
@1ambda
Copy link
Member Author

1ambda commented Mar 16, 2017

CI passed.

@AhyoungRyu
Copy link
Contributor

Merge into master if there are no more comment on this.

@asfgit asfgit closed this in 36e5f6b Mar 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants