From 39a0775a9e85ad1d4375286d9795dc6745584bb6 Mon Sep 17 00:00:00 2001
From: AhyoungRyu <fbdkdud93@hanmail.net>
Date: Sat, 25 Mar 2017 18:50:44 +0900
Subject: [PATCH 1/4] Minor styling for Heliu menu

---
 .../src/app/helium/helium.controller.js       |  5 ++
 zeppelin-web/src/app/helium/helium.css        | 14 ++++++
 zeppelin-web/src/app/helium/helium.html       | 46 +++++++++++++------
 3 files changed, 51 insertions(+), 14 deletions(-)

diff --git a/zeppelin-web/src/app/helium/helium.controller.js b/zeppelin-web/src/app/helium/helium.controller.js
index a344e801691..9158245325a 100644
--- a/zeppelin-web/src/app/helium/helium.controller.js
+++ b/zeppelin-web/src/app/helium/helium.controller.js
@@ -47,6 +47,7 @@
         }
       }
       $scope.defaultVersions = defaultVersions;
+      console.log(_.size(defaultVersions));
     };
 
     var getAllPackageInfo = function() {
@@ -215,5 +216,9 @@
         $scope.showVersions[pkgName] = true;
       }
     };
+  
+    $scope.getPackageSize = function(pkgSearchResult) {
+      return _.size(pkgSearchResult)
+    };
   }
 })();
diff --git a/zeppelin-web/src/app/helium/helium.css b/zeppelin-web/src/app/helium/helium.css
index f17d6bd31e0..d399c92dcf8 100644
--- a/zeppelin-web/src/app/helium/helium.css
+++ b/zeppelin-web/src/app/helium/helium.css
@@ -17,6 +17,16 @@
   margin-bottom: 0px;
 }
 
+.heliumLearnMore {
+  margin-top:10px;
+}
+
+.heliumLearnMore a {
+  cursor:pointer;
+  margin-right:20px;
+  text-decoration:none;
+}
+
 .heliumPackageList {
   min-height: 25px;
   margin-bottom: 15px;
@@ -105,3 +115,7 @@
   underline;color:#3071a9;
   display: inline-block;
 }
+
+.heliumVisualizationOrder p {
+  margin:0 0 5px 15px;
+}
\ No newline at end of file
diff --git a/zeppelin-web/src/app/helium/helium.html b/zeppelin-web/src/app/helium/helium.html
index 546995cb44b..aa1d759dbe1 100644
--- a/zeppelin-web/src/app/helium/helium.html
+++ b/zeppelin-web/src/app/helium/helium.html
@@ -18,32 +18,50 @@
         <h3 class="new_h3">
           Helium
         </h3>
+        <div class="pull-right heliumLearnMore">
+          <a target="_blank"
+             class="helium-repo-btn"
+             ng-href="https://zeppelin.apache.org/helium_packages.html"
+             tooltip-placement="bottom"
+             tooltip="Learn more">
+            <i class="icon-question" ng-style="{color: 'black'}"></i>
+          </a>
+        </div>
       </div>
     </div>
     <div ng-show="visualizationOrder.length > 1"
          class="row heliumVisualizationOrder">
-      <div style="margin:0 0 5px 15px">Visualization package display order (drag and drop to reorder)</div>
-      <div class="col-md-12 sortable-row btn-group"
-           as-sortable="visualizationOrderListeners"
-           data-ng-model="visualizationOrder">
-        <div class="btn-group" data-ng-repeat="pkgName in visualizationOrder"
-             as-sortable-item>
-          <div class="btn btn-default btn-sm"
-               ng-bind-html='defaultVersions[pkgName].pkg.icon'
-               as-sortable-item-handle>
+      <p>Visualization package display order (drag and drop to reorder)</p>
+      <div class="col-md-12">
+        <div class="sortable-row btn-group"
+             as-sortable="visualizationOrderListeners"
+             data-ng-model="visualizationOrder">
+          <div class="btn-group" data-ng-repeat="pkgName in visualizationOrder"
+               as-sortable-item>
+            <div class="btn btn-default btn-sm"
+                 ng-bind-html='defaultVersions[pkgName].pkg.icon'
+                 as-sortable-item-handle>
+            </div>
           </div>
         </div>
-        <span class="saveLink"
-           ng-show="visualizationOrderChanged"
-           ng-click="saveVisualizationOrder()">
-          save
-        </span>
+        <div class="saveLink"
+              ng-show="visualizationOrderChanged"
+              ng-click="saveVisualizationOrder()">
+            save
+        </div>
       </div>
     </div>
   </div>
 </div>
 
 <div class="box width-full heliumPackageContainer">
+  <div class="row"
+       style="padding-bottom: 15px"
+       ng-if="getPackageSize(defaultVersions) === 0">
+    <div class="col-md-12 gray40-message">
+      <em>Currently there is no available package to be listed</em>
+    </div>
+  </div>
   <div class="row heliumPackageList"
        ng-repeat="(pkgName, pkgInfo) in defaultVersions">
     <div class="col-md-12">

From baf4a7773373bde4dac1cc71a07de3c5441615ab Mon Sep 17 00:00:00 2001
From: AhyoungRyu <fbdkdud93@hanmail.net>
Date: Mon, 27 Mar 2017 23:48:00 +0900
Subject: [PATCH 2/4] Remove useless console log

---
 zeppelin-web/src/app/helium/helium.controller.js | 1 -
 1 file changed, 1 deletion(-)

diff --git a/zeppelin-web/src/app/helium/helium.controller.js b/zeppelin-web/src/app/helium/helium.controller.js
index 9158245325a..1488b525eb8 100644
--- a/zeppelin-web/src/app/helium/helium.controller.js
+++ b/zeppelin-web/src/app/helium/helium.controller.js
@@ -47,7 +47,6 @@
         }
       }
       $scope.defaultVersions = defaultVersions;
-      console.log(_.size(defaultVersions));
     };
 
     var getAllPackageInfo = function() {

From 84c59b520f3a06b4fc0c23de9339a09e7d6ffd89 Mon Sep 17 00:00:00 2001
From: AhyoungRyu <fbdkdud93@hanmail.net>
Date: Mon, 27 Mar 2017 23:48:51 +0900
Subject: [PATCH 3/4] Change initial sentence

---
 zeppelin-web/src/app/helium/helium.css  |  8 ++++++++
 zeppelin-web/src/app/helium/helium.html | 11 +++++++++--
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/zeppelin-web/src/app/helium/helium.css b/zeppelin-web/src/app/helium/helium.css
index d399c92dcf8..5ba8a92cfd2 100644
--- a/zeppelin-web/src/app/helium/helium.css
+++ b/zeppelin-web/src/app/helium/helium.css
@@ -118,4 +118,12 @@
 
 .heliumVisualizationOrder p {
   margin:0 0 5px 15px;
+}
+
+.gray40-message a:before {
+  content: "\00a0";
+}
+
+.gray40-message a:hover {
+  text-decoration: none;
 }
\ No newline at end of file
diff --git a/zeppelin-web/src/app/helium/helium.html b/zeppelin-web/src/app/helium/helium.html
index aa1d759dbe1..16da087813e 100644
--- a/zeppelin-web/src/app/helium/helium.html
+++ b/zeppelin-web/src/app/helium/helium.html
@@ -23,7 +23,7 @@ <h3 class="new_h3">
              class="helium-repo-btn"
              ng-href="https://zeppelin.apache.org/helium_packages.html"
              tooltip-placement="bottom"
-             tooltip="Learn more">
+             tooltip="What is Helium?">
             <i class="icon-question" ng-style="{color: 'black'}"></i>
           </a>
         </div>
@@ -59,7 +59,14 @@ <h3 class="new_h3">
        style="padding-bottom: 15px"
        ng-if="getPackageSize(defaultVersions) === 0">
     <div class="col-md-12 gray40-message">
-      <em>Currently there is no available package to be listed</em>
+      <em>No package installed</em>
+      <a target="_blank"
+         class="helium-repo-btn"
+         ng-href="https://zeppelin.apache.org/docs/{{zeppelinVersion}}/development/writingzeppelinvisualization.html#how-it-works"
+         tooltip-placement="top"
+         tooltip="How to use?">
+        <i class="icon-question" ng-style="{color: 'black'}"></i>
+      </a>
     </div>
   </div>
   <div class="row heliumPackageList"

From b658fcfbd9011a98cc59393d3ac9e6879e116892 Mon Sep 17 00:00:00 2001
From: AhyoungRyu <fbdkdud93@hanmail.net>
Date: Mon, 27 Mar 2017 23:51:44 +0900
Subject: [PATCH 4/4] Remove underline when icon btn activated

---
 zeppelin-web/src/app/helium/helium.css | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/zeppelin-web/src/app/helium/helium.css b/zeppelin-web/src/app/helium/helium.css
index 5ba8a92cfd2..1d1a0562a51 100644
--- a/zeppelin-web/src/app/helium/helium.css
+++ b/zeppelin-web/src/app/helium/helium.css
@@ -126,4 +126,8 @@
 
 .gray40-message a:hover {
   text-decoration: none;
-}
\ No newline at end of file
+}
+
+.gray40-message a:focus {
+  text-decoration: none;
+}