From e53edc0db1b3314dc1cd606f2ab7d1d597836e53 Mon Sep 17 00:00:00 2001 From: Khalid Huseynov Date: Mon, 3 Apr 2017 17:27:42 +0900 Subject: [PATCH 1/2] remove init controller on note_info --- zeppelin-web/src/app/notebook/notebook.controller.js | 5 ----- 1 file changed, 5 deletions(-) diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 7846725f8e0..5fde0f49c41 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -128,11 +128,6 @@ function NotebookCtrl($scope, $route, $routeParams, $location, $rootScope, initNotebook(); - // force notebook reload on user change - $scope.$on('setNoteMenu', function(event, note) { - initNotebook(); - }); - $scope.focusParagraphOnClick = function(clickEvent) { if (!$scope.note) { return; From 74543368768ae6f30bb8d8e3769fff5ffe3e4e26 Mon Sep 17 00:00:00 2001 From: Khalid Huseynov Date: Tue, 4 Apr 2017 16:09:19 +0900 Subject: [PATCH 2/2] fix js test --- zeppelin-web/src/app/notebook/notebook.controller.test.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/zeppelin-web/src/app/notebook/notebook.controller.test.js b/zeppelin-web/src/app/notebook/notebook.controller.test.js index df90c81c94e..6df6893aa09 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.test.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.test.js @@ -126,14 +126,14 @@ describe('Controller: NotebookCtrl', function() { spyOn(websocketMsgSrvMock, 'listRevisionHistory'); scope.$broadcast('setNoteMenu'); - expect(websocketMsgSrvMock.getNote.calls.count()).toEqual(1); - expect(websocketMsgSrvMock.listRevisionHistory.calls.count()).toEqual(1); + expect(websocketMsgSrvMock.getNote.calls.count()).toEqual(0); + expect(websocketMsgSrvMock.listRevisionHistory.calls.count()).toEqual(0); websocketMsgSrvMock.getNote.calls.reset(); websocketMsgSrvMock.listRevisionHistory.calls.reset(); scope.$broadcast('setNoteMenu'); - expect(websocketMsgSrvMock.getNote.calls.count()).toEqual(1); - expect(websocketMsgSrvMock.listRevisionHistory.calls.count()).toEqual(1); + expect(websocketMsgSrvMock.getNote.calls.count()).toEqual(0); + expect(websocketMsgSrvMock.listRevisionHistory.calls.count()).toEqual(0); }); });