From ba59a7772185ce01b2aa04898a122bc507de37a7 Mon Sep 17 00:00:00 2001 From: Jeff Zhang Date: Sun, 16 Apr 2017 16:38:36 +0800 Subject: [PATCH] ZEPPELIN-2407. Livy Interpreter always return plain text result --- .../zeppelin/livy/BaseLivyInterprereter.java | 2 +- .../apache/zeppelin/livy/LivyInterpreterIT.java | 16 +++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java b/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java index 8fd06489da6..ce9e7061a52 100644 --- a/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java +++ b/livy/src/main/java/org/apache/zeppelin/livy/BaseLivyInterprereter.java @@ -371,7 +371,7 @@ private InterpreterResult getResultFromStatementInfo(StatementInfo stmtInfo, if (displayAppInfo) { InterpreterResult interpreterResult = new InterpreterResult(InterpreterResult.Code.SUCCESS); - interpreterResult.add(InterpreterResult.Type.TEXT, result); + interpreterResult.add(result); String appInfoHtml = "
Spark Application Id: " + sessionInfo.appId + "
" + "Spark WebUI: " + sessionInfo.webUIAddress + ""; diff --git a/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java b/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java index 3da908c8fdd..0ae948a1ab1 100644 --- a/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java +++ b/livy/src/test/java/org/apache/zeppelin/livy/LivyInterpreterIT.java @@ -145,6 +145,13 @@ public void testSparkInterpreterRDD() { assertTrue(result.message().get(0).getData().contains("defined object Person")); } + // html output + String htmlCode = "println(\"%html

hello

\")"; + result = sparkInterpreter.interpret(htmlCode, context); + assertEquals(InterpreterResult.Code.SUCCESS, result.code()); + assertEquals(1, result.message().size()); + assertEquals(InterpreterResult.Type.HTML, result.message().get(0).getType()); + // error result = sparkInterpreter.interpret("println(a)", context); assertEquals(InterpreterResult.Code.ERROR, result.code()); @@ -544,8 +551,15 @@ public void testSparkInterpreterWithDisplayAppInfo() { InterpreterResult result = sparkInterpreter.interpret("sc.version", context); assertEquals(InterpreterResult.Code.SUCCESS, result.code()); assertEquals(2, result.message().size()); - assertTrue(result.message().get(1).getData().contains("Spark Application Id")); + + // html output + String htmlCode = "println(\"%html

hello

\")"; + result = sparkInterpreter.interpret(htmlCode, context); + assertEquals(InterpreterResult.Code.SUCCESS, result.code()); + assertEquals(2, result.message().size()); + assertEquals(InterpreterResult.Type.HTML, result.message().get(0).getType()); + } finally { sparkInterpreter.close(); }