ZEPPELIN-2421. AngularObject miss AngularObjectListener when it is pushed from frontend#2263
Closed
zjffdu wants to merge 1 commit into
Closed
ZEPPELIN-2421. AngularObject miss AngularObjectListener when it is pushed from frontend#2263zjffdu wants to merge 1 commit into
zjffdu wants to merge 1 commit into
Conversation
…shed from frontend
Contributor
Author
|
@Leemoonsoo Please help review. |
Member
|
Thanks @zjffdu for the fix. |
Contributor
Author
|
Thanks @Leemoonsoo , will merge it if no more comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This bug happens when you save your note, and restart zeppelin and run it again. The root cause is that the angular object miss AngularObjectListener which means you can not sync up the changes on angular object to frontend. This PR would restore the listener correctly when we restore the angular objects saved before. Also make some changes for logging in this PR.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Tested manually
Screenshots (if appropriate)
Before
After
Questions: