Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE #2721

Closed
wants to merge 1 commit into from

Conversation

prabhjyotsingh
Copy link
Contributor

What is this PR for?

Zepplin UI Doesn't logs out in IE/Edge, its Shows Logout Success and automatically reload the page
But the User is still logged in.

This happens when shiro is configured with "authc" however it works for "authcBasic".

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

  • Logout should work for all browsers and for both shiro configuration i.e. "authc" and "authcBasic"

Questions:

  • Does the licenses files need update? N/A
  • Is there breaking changes for older versions? N/A
  • Does this needs documentation? N/A

@prabhjyotsingh prabhjyotsingh changed the title ZEPPELIN-3129: Zepplin UI Doesnt logs out in IE [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE Jan 9, 2018
@prabhjyotsingh
Copy link
Contributor Author

prabhjyotsingh commented Jan 9, 2018

Have tested this on FF31, FF57, Chrome-63, Safari-11, Windows7's IE-12 and Windows10's Edge-25

@Akhilsnaik
Copy link

Have Tested in Windows 7 IE 11 ,
The Fix works fine in IE 11.

@prabhjyotsingh
Copy link
Contributor Author

Thanks for the review will merge this if no more discussion.

@asfgit asfgit closed this in 346981b Jan 13, 2018
@prabhjyotsingh prabhjyotsingh deleted the ZEPPELIN-3129 branch May 2, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants