From beec1a36bbc0a5d3a6e8ab2ae3b46304539d184c Mon Sep 17 00:00:00 2001
From: liuxunorg <33611720@qq.com>
Date: Wed, 5 Sep 2018 19:06:37 +0800
Subject: [PATCH] [ZEPPELIN-3689] Shade all dependencies of
 zeppelin-interpreter

### What is this PR for?

The custom interpreter may add other dependencies which conflict with zeppelin-interpreter's dependency, so it is better to shade zeppelin-interpreter's dependencies.

### What type of PR is it?
[Improve]

### Todos
* [x] Added new module interpreter-api to shade all dependencies of zeppelin-interpreter
* [x] Add maven-shade-plugin to interpreter-api/pom.xml
* [x] Add maven-surefire-plugin to interpreter-api/pom.xml
* [x] filter META-INF/*.SF, META-INF/*.DSA, META-INF/*.RSA
* [x] dependency the interpreter-api module in the  zeppelin-interpreter/pom file
* [x] Exclude the interpreter-api module in the interpreter-parent/pom file to avoid dependency package conflicts
* [x] Exclude the interpreter-api module in the zeppelin-display/pom file to avoid dependency package conflicts
* [x] Exclude the interpreter-api module in the zeppelin-zengine/pom file to avoid dependency package conflicts

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3689

### How should this be tested?
CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
---
 interpreter-api/pom.xml      | 136 +++++++++++++++++++++++++++++++++++
 interpreter-parent/pom.xml   |   6 ++
 pom.xml                      |   1 +
 zeppelin-display/pom.xml     |   6 ++
 zeppelin-interpreter/pom.xml |   5 ++
 zeppelin-zengine/pom.xml     |   6 ++
 6 files changed, 160 insertions(+)
 create mode 100644 interpreter-api/pom.xml

diff --git a/interpreter-api/pom.xml b/interpreter-api/pom.xml
new file mode 100644
index 00000000000..b6e238378e4
--- /dev/null
+++ b/interpreter-api/pom.xml
@@ -0,0 +1,136 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  ~ Licensed to the Apache Software Foundation (ASF) under one or more
+  ~ contributor license agreements.  See the NOTICE file distributed with
+  ~ this work for additional information regarding copyright ownership.
+  ~ The ASF licenses this file to You under the Apache License, Version 2.0
+  ~ (the "License"); you may not use this file except in compliance with
+  ~ the License.  You may obtain a copy of the License at
+  ~
+  ~    http://www.apache.org/licenses/LICENSE-2.0
+  ~
+  ~ Unless required by applicable law or agreed to in writing, software
+  ~ distributed under the License is distributed on an "AS IS" BASIS,
+  ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  ~ See the License for the specific language governing permissions and
+  ~ limitations under the License.
+  -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+
+  <modelVersion>4.0.0</modelVersion>
+
+  <parent>
+    <artifactId>zeppelin</artifactId>
+    <groupId>org.apache.zeppelin</groupId>
+    <version>0.9.0-SNAPSHOT</version>
+    <relativePath>..</relativePath>
+  </parent>
+
+  <groupId>org.apache.zeppelin</groupId>
+  <artifactId>interpreter-api</artifactId>
+  <packaging>jar</packaging>
+  <version>0.9.0-SNAPSHOT</version>
+  <name>Zeppelin: Interpreter API</name>
+  <description>Shade all dependencies of zeppelin-interpreter</description>
+
+  <properties>
+    <!--library versions-->
+    <maven.plugin.api.version>3.0</maven.plugin.api.version>
+    <!--plugin versions-->
+    <plugin.shade.version>2.3</plugin.shade.version>
+  </properties>
+
+  <dependencies>
+    <!-- Aether :: maven dependency resolution -->
+    <dependency>
+      <groupId>org.apache.maven</groupId>
+      <artifactId>maven-plugin-api</artifactId>
+      <version>${maven.plugin.api.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>org.codehaus.plexus</groupId>
+          <artifactId>plexus-utils</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.sonatype.sisu</groupId>
+          <artifactId>sisu-inject-plexus</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>org.apache.maven</groupId>
+          <artifactId>maven-model</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <resources>
+      <resource>
+        <directory>src/main/resources</directory>
+        <filtering>true</filtering>
+      </resource>
+    </resources>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-checkstyle-plugin</artifactId>
+        <configuration>
+          <skip>false</skip>
+        </configuration>
+      </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-dependency-plugin</artifactId>
+      </plugin>
+
+      <plugin>
+        <artifactId>maven-surefire-plugin</artifactId>
+        <version>${plugin.surefire.version}</version>
+        <configuration combine.children="append">
+          <argLine>-Xmx2g -Xms1g -Dfile.encoding=UTF-8</argLine>
+          <excludes>
+            <exclude>${tests.to.exclude}</exclude>
+          </excludes>
+          <environmentVariables>
+            <ZEPPELIN_FORCE_STOP>1</ZEPPELIN_FORCE_STOP>
+          </environmentVariables>
+        </configuration>
+      </plugin>
+
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-shade-plugin</artifactId>
+        <executions>
+          <execution>
+            <phase>package</phase>
+            <goals>
+              <goal>shade</goal>
+            </goals>
+            <configuration>
+              <filters>
+                <filter>
+                  <artifact>*:*</artifact>
+                  <excludes>
+                    <exclude>META-INF/*.SF</exclude>
+                    <exclude>META-INF/*.DSA</exclude>
+                    <exclude>META-INF/*.RSA</exclude>
+                  </excludes>
+                </filter>
+              </filters>
+              <transformers>
+                <transformer implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
+                <transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
+                  <resource>reference.conf</resource>
+                </transformer>
+              </transformers>
+            </configuration>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+
+</project>
\ No newline at end of file
diff --git a/interpreter-parent/pom.xml b/interpreter-parent/pom.xml
index 25af44140aa..57f123e7829 100644
--- a/interpreter-parent/pom.xml
+++ b/interpreter-parent/pom.xml
@@ -38,6 +38,12 @@
         <groupId>${project.groupId}</groupId>
         <artifactId>zeppelin-interpreter</artifactId>
         <version>${project.version}</version>
+        <exclusions>
+          <exclusion>
+            <groupId>${project.groupId}</groupId>
+            <artifactId>interpreter-api</artifactId>
+          </exclusion>
+        </exclusions>
       </dependency>
 
       <dependency>
diff --git a/pom.xml b/pom.xml
index 60af8bca62a..b3c1b911933 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,6 +52,7 @@
   <inceptionYear>2013</inceptionYear>
 
   <modules>
+    <module>interpreter-api</module>
     <module>interpreter-parent</module>
     <module>zeppelin-interpreter</module>
     <module>zeppelin-zengine</module>
diff --git a/zeppelin-display/pom.xml b/zeppelin-display/pom.xml
index 79a08a69a6d..9325b748e67 100644
--- a/zeppelin-display/pom.xml
+++ b/zeppelin-display/pom.xml
@@ -69,6 +69,12 @@
       <groupId>${project.groupId}</groupId>
       <artifactId>zeppelin-interpreter</artifactId>
       <version>${project.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>${project.groupId}</groupId>
+          <artifactId>interpreter-api</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
 
     <dependency>
diff --git a/zeppelin-interpreter/pom.xml b/zeppelin-interpreter/pom.xml
index 4ee10806922..88efeeebc39 100644
--- a/zeppelin-interpreter/pom.xml
+++ b/zeppelin-interpreter/pom.xml
@@ -50,6 +50,11 @@
   </properties>
 
   <dependencies>
+    <dependency>
+      <groupId>${project.groupId}</groupId>
+      <artifactId>interpreter-api</artifactId>
+      <version>${project.version}</version>
+    </dependency>
 
     <dependency>
       <groupId>org.apache.thrift</groupId>
diff --git a/zeppelin-zengine/pom.xml b/zeppelin-zengine/pom.xml
index d37f6eab88d..3d36b07b934 100644
--- a/zeppelin-zengine/pom.xml
+++ b/zeppelin-zengine/pom.xml
@@ -55,6 +55,12 @@
       <groupId>${project.groupId}</groupId>
       <artifactId>zeppelin-interpreter</artifactId>
       <version>${project.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>${project.groupId}</groupId>
+          <artifactId>interpreter-api</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
 
     <dependency>