Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-3983. Travis fails due to downloading spark takes a lot of time #3300

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@zjffdu
Copy link
Contributor

commented Feb 2, 2019

What is this PR for?

This PR did several refactoring.

  • rename SparkDownloadUtils -> DownloadUtils as it is also used for downloading flink.
  • try apache mirror just one time and fall back to apache archive when fails to download from mirror site.

What type of PR is it?

[Refactoring]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No
@felixcheung
Copy link
Member

left a comment

still lots of duplicated code? I mean the differences are in downloadFile and downloadURL only the filename part "/flink-" + version + "-bin-hadoop27-scala_2.11.tgz"

@zjffdu zjffdu force-pushed the zjffdu:ZEPPELIN-3983 branch from a526001 to c822e24 Feb 2, 2019

@zjffdu

This comment has been minimized.

Copy link
Contributor Author

commented Feb 2, 2019

@felixcheung Thanks for review, I did more refactoring

}
}
} catch (IOException ioe) {
ioe.printStackTrace();

This comment has been minimized.

Copy link
@felixcheung

felixcheung Feb 4, 2019

Member

LOGGER.warn()?

This comment has been minimized.

Copy link
@zjffdu

zjffdu Feb 11, 2019

Author Contributor

Fixed

@felixcheung

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

LGTM

@Leemoonsoo

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

Looks great! +1

@zjffdu zjffdu force-pushed the zjffdu:ZEPPELIN-3983 branch from c822e24 to d63826c Feb 11, 2019

@zjffdu zjffdu force-pushed the zjffdu:ZEPPELIN-3983 branch from d63826c to 5201746 Feb 11, 2019

@asfgit asfgit closed this in 727600b Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.