Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4014] Show note name on the search list, not the note id #3436

Closed
wants to merge 1 commit into from

Conversation

milooy
Copy link
Contributor

@milooy milooy commented Sep 2, 2019

What is this PR for?

The note IDs were shown on the search list(even if it's filtered by note's name)
Need to show note name rather than id.

What type of PR is it?

Bug Fix

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4014

How should this be tested?

Screenshots (if appropriate)

(Before: Notebook IDs are shown)
image

(After: Notebook names are shown)
image

Questions:

  • Does the licenses files need update?
  • Is there breaking changes for older versions?
  • Does this needs documentation?

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable, this looks to affect other place possibly too? also could we have some test for this

@zjffdu
Copy link
Contributor

zjffdu commented Sep 3, 2019

Thanks @milooy for the contribution, LGTM

@asfgit asfgit closed this in 08d4b9a Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants