[ZEPPELIN-4476] Running Trash Restore will result in an error#3549
Closed
eldiem wants to merge 3 commits into
Closed
[ZEPPELIN-4476] Running Trash Restore will result in an error#3549eldiem wants to merge 3 commits into
eldiem wants to merge 3 commits into
Conversation
zjffdu
reviewed
Dec 10, 2019
| NoteManager.Folder trash = noteManager.getTrashFolder(); | ||
| // restore notes under trash folder | ||
| for (NoteManager.NoteNode noteNode : trash.getNotes().values()) { | ||
| List<NoteNode> notes = trash.getNotes().values().stream().collect(Collectors.toList()); |
Contributor
There was a problem hiding this comment.
Could you add one line of comment to explain why we need to do like this ? So that others won't refactor it in future
Contributor
|
Thanks @eldiem LGTM, will merge if no more comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If you run a restore when there are two or more notes or folders, an error occurs.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4476
How should this be tested?
(before)
(after)
