Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-391] Keyboard shortcut #569

Closed
wants to merge 12 commits into from

Conversation

@Leemoonsoo
Copy link
Member

@Leemoonsoo Leemoonsoo commented Dec 24, 2015

What is this PR for?

This PR implements keyboard shortcuts for paragraph control.

What type of PR is it?

Feature

Is there a relevant Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-391

How should this be tested?

Try implemented shortcuts

Ctrl + Alt + c : Cancel run
Ctrl + Alt + d : Remove paragraph
Ctrl + Alt + k : Move paragraph Up
Ctrl + Alt + j : Move paragraph Down
Ctrl + Alt + b : Insert new paragraph below
Ctrl + Alt + o : Toggle output
Ctrl + Alt + e : Toggle editor
Ctrl + Alt + m : Toggle line numbers
Ctrl + Alt + t : Toggle title
Ctrl + Alt + 10,-,+ : Paragraph width from 112

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no
@Leemoonsoo
Copy link
Member Author

@Leemoonsoo Leemoonsoo commented Dec 24, 2015

Please review

image

Leemoonsoo added 2 commits Dec 25, 2015
@minahlee
Copy link
Member

@minahlee minahlee commented Dec 25, 2015

Ctrl + c is commonly used to copy highlighted text to the clipboard so better to change.

@Leemoonsoo
Copy link
Member Author

@Leemoonsoo Leemoonsoo commented Dec 25, 2015

@minahlee You're right. Changed to Ctrl+Alt+c

@minahlee
Copy link
Member

@minahlee minahlee commented Dec 25, 2015

Ctrl + Alt + k and Ctrl + Alt + E does work on chrome, firefox but not on IE

@Leemoonsoo
Copy link
Member Author

@Leemoonsoo Leemoonsoo commented Dec 26, 2015

@minahlee Some more shortcuts are not working in IE. for example Ctrl + n, Ctrl + p.
Do you mind handle shortcuts on IE separately?

@minahlee
Copy link
Member

@minahlee minahlee commented Dec 26, 2015

@Leemoonsoo
Copy link
Member Author

@Leemoonsoo Leemoonsoo commented Dec 27, 2015

I'll create an issue for shortcut on IE.
Merge if there're no more discussions

@asfgit asfgit closed this in 0a68c0b Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants