Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-3532 Provide a docker-based environment to work on a known OS #1075

Closed
wants to merge 2 commits into from

Conversation

@eolivelli
Copy link
Contributor

eolivelli commented Sep 3, 2019

Just run dev/docker/run.sh and you will have a Linux environment with all that is needed to build ZooKeeper, even on MacOs.

The original idea patch was from Sijie Guo (@sijie), Apache BookKeeper project.

The script creates a local image that accesses the local filesystem with the current user (UID), this way the container can work on local files without problems of ownership of files.

UserSpecificDocker

BOOKKEEPER_ROOT=${SCRIPT_DIR}/../..

This comment has been minimized.

Copy link
@maoling

maoling Sep 3, 2019

Contributor

BOOKKEEPER_ROOT ?

This comment has been minimized.

Copy link
@eolivelli

eolivelli Sep 3, 2019

Author Contributor

good catch, it was from BOOKKEEPER the script I will update

@maoling

This comment has been minimized.

Copy link
Contributor

maoling commented Sep 3, 2019

I also recently filed ZOOKEEPER-3527 and write an email to @31z4 who is maintaining the official zookeeper image, whether he can contribute the dockerfile and all the related docker stuff to the zookeeper trunk for more people involved and maintained.

@eolivelli

This comment has been minimized.

Copy link
Contributor Author

eolivelli commented Sep 3, 2019

@maoling this docker file is only useful in order to create a local developer workstation, it is not meant to be the Docker file for running a ZK server.
In fact it is inside "dev" folder

Enrico Olivelli
@eolivelli

This comment has been minimized.

Copy link
Contributor Author

eolivelli commented Sep 3, 2019

@maoling I have addressed your comments

@hanm

This comment has been minimized.

Copy link
Contributor

hanm commented Sep 3, 2019

looks good.

A side note is I've been using https://github.com/phunt/zk-docker-devenv from @phunt, works great (in particular, for Kerberos related development that saves ton of time). Might worth consider adding something similar to zookeeper if we are not merging pat's script.

@eolivelli

This comment has been minimized.

Copy link
Contributor Author

eolivelli commented Sep 3, 2019

@hanm @phunt images looks cool.

I don't know if we need this patch

I can add that in Bookkeeper we are using this as base for using docker in ASF CI

We also use docker in order to create release candidates with a well know env (not with this Dockerfile)

@hanm

This comment has been minimized.

Copy link
Contributor

hanm commented Sep 5, 2019

I don't know if we need this patch

what's your plan with this patch @eolivelli ? should we merge it? it seems good to have a docker presence in our code base (similar to hadoop / hbase / bk / possibly others), the only implication is we'd have to maintain the scripts moving forward. Do we need a DISCUSS on dev thread about this?

@eolivelli

This comment has been minimized.

Copy link
Contributor Author

eolivelli commented Sep 6, 2019

I saw Patrick's work, it is awesome.

My final take is that it is better to merge this patch, it is a simple environment but it has all that is needed to work on ZK.

When I have cycles I will try to port from BK the other stuff for CI and for the release procedure.

Please help merging it @hanm thanks

@hanm
hanm approved these changes Sep 9, 2019
@asfgit asfgit closed this in a0f500b Sep 9, 2019
eolivelli pushed a commit that referenced this pull request Sep 11, 2019
Just run dev/docker/run.sh and you will have a Linux environment with all that is needed to build ZooKeeper, even on MacOs.

The original idea patch was from Sijie Guo (sijie), Apache BookKeeper project.

The script creates a local image that accesses the local filesystem with the current user (UID), this way the container can work on local files without problems of ownership of files.

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: maoling <maoling199210191@sina.com>, Michael Han <hanm@apache.org>

Closes #1075 from eolivelli/fix/docker-env
eolivelli pushed a commit that referenced this pull request Sep 11, 2019
Just run dev/docker/run.sh and you will have a Linux environment with all that is needed to build ZooKeeper, even on MacOs.

The original idea patch was from Sijie Guo (sijie), Apache BookKeeper project.

The script creates a local image that accesses the local filesystem with the current user (UID), this way the container can work on local files without problems of ownership of files.

Author: Enrico Olivelli <enrico.olivelli@diennea.com>

Reviewers: maoling <maoling199210191@sina.com>, Michael Han <hanm@apache.org>

Closes #1075 from eolivelli/fix/docker-env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.