Li dev/base 3.8.4 #2317
Closed
Li dev/base 3.8.4 #2317
+6,391
−2,566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NOTICE.txt file More context here: https://issues.apache.org/jira/browse/ZOOKEEPER-4315 Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org> Closes apache#1812 from eolivelli/ZOOKEEPER-4315-notice (cherry picked from commit ebcf18e) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
…format The BCFKS keystore/truststore format support was backported to branch 3.5, I updated the documentation. Author: Mate Szalay-Beko <mszalay@cloudera.com> Reviewers: Norbert Kalmar <nkalmar@apache.org>, Andor Molnar <andor@apache.org> Closes apache#1816 from symat/ZOOKEEPER-4468-doc-update (cherry picked from commit 0b0dfe5) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
More context here: https://issues.apache.org/jira/browse/ZOOKEEPER-4469 I am also updating the OWASP dependency check Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Norbert Kalmar <nkalmar@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1817 from eolivelli/ZOOKEEPER-4469 (cherry picked from commit 428e6f9) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…' and ')'
zooinspect logback config file `logback.xml` currently use a pattern of this
`<pattern>%5p [%t] (%F:%L) - %m%n</pattern> `
which not escape the '(' and ')', cause logback to ignore parts after ')'.
according to logback documents, '(' and ')' is used for grouping, need escape by `\` if used as normal char
https://logback.qos.ch/manual/layouts.html#grouping
this pr update it to (add '\' to escape)
`<pattern>%5p [%t] \(%F:%L\) - %m%n</pattern> `
Author: 67 <67@gd67.com>
Reviewers: Enrico Olivelli <eolivelli@apache.org>, Andor Molnar <andor@apache.org>, Mate Szalay-Beko <symat@apache.org>
Closes apache#1814 from iamgd67/ZOOKEEPER-4465
(cherry picked from commit 48191b6)
Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…NAPSHOT.jar: CVE-2021-29425, CVE-2021-28164, CVE-2021-34429 Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org> Closes apache#1824 from eolivelli/ZOOKEEPER-4478-owasp (cherry picked from commit 3004c90) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
…l future renewals since Java 9 This bug is similar to the one fixed in https://issues.apache.org/jira/browse/KAFKA-12730. Our Kerberos ticket refresh thread performs re-login by logging out and then logging in again. If login fails, we retry after some sleep. Every reLogin() operation performs loginContext.logout() and loginContext.login(). If login fails, we end up with two consecutive logouts. This used to work in older Java versions, but from Java 9 onwards, this results in a NullPointerException due to https://bugs.openjdk.java.net/browse/JDK-8173069. We should check if logout is required before attempting logout. I fixed the issue and added a new unit test to test some ticket renewal scenarios. I managed to reproduce the problem in KerberosTicketRenewalTest.shouldRecoverIfKerberosNotAvailableForSomeTime() which (before the fix) failed with Java13 but succeeded with Java8. Author: Mate Szalay-Beko <symat@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1828 from symat/ZOOKEEPER-4477-master (cherry picked from commit a5b6c38) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
With these commits, the various tests in `TestOperations.cc` set the `last_sent` and `last_recv` fields of the "force-connected" ZooKeeper handle to deterministic values (which match the initial value of the time mock). When that value is not specified, these fields get set to the "real" time at the end of the `forceConnected` function, which can be sufficiently different from the value held in the mock for some of the tests to fail. Author: Damien Diederen <ddiederen@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1827 from ztzg/ZOOKEEPER-4479-flaky-c-test-operations (cherry picked from commit 640b6dd) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
…te fix zooInspector root child creates fail with path validate fix. create node update UI only if creation success, if fail show message dialog about the reason. add basic ZooInspectorManagerImpl tests using mocked zookeeper client. Author: 67 <67@gd67.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1818 from iamgd67/ZOOKEEPER-4473 (cherry picked from commit 99cb20e) Signed-off-by: Mate Szalay-Beko <symat@apache.org>
…le internal value When packets are added to ClientCnxn's outgoing packet queue we ensure there's no conflict with an ongoing flush of that queue because of connection loss. Synchronization used to be on the state field's value. This value is both not stable (its value changes over time), possibly causing improper synchronization, and global, which can cause contention in applications that run several ZooKeeper clients. We now synchronize on outgoingQueue which is both local to a ClientCnxn's instance and stable. Author: Sylvain Wallez <sylvain@bluxte.net> Reviewers: maoling <maoling@apache.org>, Mohammad Arshad <arshad@apache.org> Closes apache#1257 from swallez/ZOOKEEPER-3652 and squashes the following commits: 82e2cad [Sylvain Wallez] Instruct SpotBugs that we know what we're doing when synchronizing on outgoingQueue b0bc03d [Sylvain Wallez] ZOOKEEPER-3652: Synchronize ClientCnxn outgoing queue flush on a stable internal value (cherry picked from commit 91e0520) Signed-off-by: Mohammad Arshad <arshad@apache.org>
CVE-2020-36518 vulnerability affects jackson-databind in Zookeeper (see GHSA-57j2-w4cx-62h2). Upgrading to jackson-databind version 2.13.2.1 should address this issue. Author: Edwin Hobor <edwinhobor@gmail.com> Reviewers: maoling <maoling@apache.org>,Enrico Olivelli <eolivelli@apache.org>, Mohammad Arshad <arshad@apache.org> Closes apache#1842 from edwin092/edwin/ZOOKEEPER-4505 (cherry picked from commit 78bbb12) Signed-off-by: Mohammad Arshad <arshad@apache.org>
…nctionality Make ZKUtil#deleteRecursive API fully compatible with older versions Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1843 from arshadmohammad/ZOOKEEPER-4504-DeleteRecursive and squashes the following commits: 851bb1e [Mohammad Arshad] Added javadoc for ZKUtil#deleteRecursive(zk, pathRoot, batchSize) API e7b3311 [Mohammad Arshad] Added test case to verify ZKUtil.deleteRecursive() in sync and async mode 008b2bd [Mohammad Arshad] ZOOKEEPER-4504: ZKUtil#deleteRecursive causing deadlock in HDFS HA functionality (cherry picked from commit 54cb5c3) Signed-off-by: Mohammad Arshad <arshad@apache.org>
Moved channel object null check to sendPkt method to cover all calling scenarios Author: Mohammad Arshad <arshad@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org> Closes apache#1854 from arshadmohammad/ZOOKEEPER-4514-npe (cherry picked from commit d5876e8) Signed-off-by: Mohammad Arshad <arshad@apache.org>
1. For connection closing state scenario, changed the log level to debug 2. When JVM exiting with code 0, then logging info instead of error Author: Mohammad Arshad <arshad@apache.org> Reviewers: tison <wander4096@gmail.com>, Enrico Olivelli <eolivelli@apache.org> Closes apache#1856 from arshadmohammad/ZOOKEEPER-4515-cli and squashes the following commits: e7e248b [Mohammad Arshad] Logging error only when exit code is non zero 31e124a [Mohammad Arshad] ZOOKEEPER-4515: ZK Cli quit command always logs error 1. For connection closing state scenario, changed the log level to debug 2. When JVM exiting with code 0, then logging info instead of error (cherry picked from commit e5f84f4) Signed-off-by: Mohammad Arshad <arshad@apache.org>
…sEvent Author: Mohammad Arshad <arshad@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org>, Enrico Olivelli <eolivelli@apache.org> Closes apache#1855 from arshadmohammad/ZOOKEEPER-1875-npe and squashes the following commits: 4a7d471 [Mohammad Arshad] Corrected impacted test cases 12f44d6 [Mohammad Arshad] ZOOKEEPER-1875: NullPointerException in ClientCnxn$EventThread.processEvent (cherry picked from commit 86690ff) Signed-off-by: Mohammad Arshad <arshad@apache.org>
…VE-2020-9493, CVE-2022-23307 Upgraded dependency-check-maven plugin from 6.5.3 to 7.1.0 Author: Mohammad Arshad <arshad@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>, ZhangJian He <shoothzj@apache.org> Closes apache#1872 from arshadmohammad/ZOOKEEPER-4510-upgrade (cherry picked from commit 2407388) Signed-off-by: Enrico Olivelli <eolivelli@apache.org>
upgrading netty in master as per review in : apache#1867 Author: Ananya Singh <purpul90@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Shoothzj <shoothzj@gmail.com>, Mohammad Arshad <arshad@apache.org>, Brahma Reddy Battula <brahma@apache.org> Closes apache#1869 from AnanyaSingh2121/ZK-4529 (cherry picked from commit aab3ff6) Signed-off-by: Mohammad Arshad <arshad@apache.org>
Removed tcnative depdency as it is required after netty upgrade to 4.1.76 Removed tcnative CVE supressions Author: Brahma Reddy Battula <brahma@apache.org> Reviewers: Mohammad Arshad <arshad@apache.org> Closes apache#1873 from brahmareddybattula/master (cherry picked from commit 5b6823a) Signed-off-by: Mohammad Arshad <arshad@apache.org>
Zookeeper server can get stuck when it has just one client and the only way it recovers is due to a socket timeout or another client commit request. Sync thread reads commitIsWaiting outside of a sync block and acts on this information in a sync block later. The actual status of commitIsWaiting can change between the time where commitIsWaiting is read and acted upon because commit thread updates it outside a sync block. Fix here is to ensure that we read and process commitIsWaiting inside a sync block. https://issues.apache.org/jira/browse/ZOOKEEPER-4537 Author: jithin23 <jithin.girish@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1877 from jithin23/ZOOKEEPER-4537 (cherry picked from commit f770467) Signed-off-by: Mate Szalay-Beko <mszalay@cloudera.com>
…ling This test failed following assertions in ci: 1. `RequestThrottlerTest.testRequestThrottler:206 expected: <5> but was: <4>` This is caused by no happens-before relationship between `connectionLossCount` and `disconnected.await`. Places `disconnected.countDown()` after `connectionLossCount++` to solve this. 2. `RequestThrottlerTest.testLargeRequestThrottling:297 expected: <2> but was: <0>` Large request throttling is handled in io thread, while `prep_processor_request_queued` metric is updated in processor thread. Places metric assertion after `finished.await` to solve this. Additionally, I find one more potential flaky case. After connection closed due to throttling third request, reconnecting could fail this test in slow sending environment. It is easy to reproduce by adding `Thread.sleep(i * 100)` in sending loop. Author: Kezhu Wang <kezhuw@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1821 from kezhuw/ZOOKEEPER-4327-flaky-RequestThrottlerTest.testLargeRequestThrottling and squashes the following commits: e21c2f8 [Kezhu Wang] ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testDropStaleRequests 3df34b8 [Kezhu Wang] ZOOKEEPER-4327: Fix flaky RequestThrottlerTest.testLargeRequestThrottling (cherry picked from commit 4b1b33e) Signed-off-by: maoling <maoling@apache.org>
… connection Motivation: See more here https://issues.apache.org/jira/browse/ZOOKEEPER-4551 Modifications: Do not log the stacktrace, just write the message at INFO level Author: Enrico Olivelli <eolivelli@apache.org> Reviewers: Mate Szalay-Beko <symat@apache.org> Closes apache#1889 from eolivelli/fix/remove-spam-stacktrace (cherry picked from commit 7a515fe) Signed-off-by: Mate Szalay-Beko <symat@apache.com>
There are several problems in this test: * It uses `ParameterizedTest` which run tests in single jvm. But `ZooKeeperServer.enableEagerACLCheck` is `static` and loaded from env variable. * It uses `assertNotSame` which assert on object reference equiality. * It asserts on `zkLeader.getLastLoggedZxid()` while client connect to `connectedServer`. There is no happen-before between `zkLeader.getLastLoggedZxid()` and successful response from other server. The commit and response are routed to different servers and performed asynchronous in each server. Author: Kezhu Wang <kezhuw@gmail.com> Reviewers: maoling <maoling199210191@sina.com>, Mate Szalay-Beko <symat@apache.org> Closes apache#1851 from kezhuw/ZOOKEEPER-4308-EagerACLFilterTest (cherry picked from commit 794790c) Signed-off-by: Mate Szalay-Beko <symat@apache.com>
…napLogMetrics This test writes txns to trigger snapshot and expects some txns remain in txn log. But snapshot taking is asynchronous, thus all txns could be written to snapshot. So in restarting, it is possible that no txns to load after snapshot restored. This will fail assertion. This commit solves this by disable automic snapshot taking by `SyncRequestProcessor.setSnapCount(Integer.MAX_VALUE)`. Author: Kezhu Wang <kezhuw@gmail.com> Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org> Closes apache#1852 from kezhuw/ZOOKEEPER-4511-FileTxnSnapLogMetricsTest-testFileTxnSnapLogMetrics (cherry picked from commit b34e171) Signed-off-by: Mate Szalay-Beko <symat@apache.com>
```java
if (serverPath.length() > chrootPath.length()) {
event.setPath(serverPath.substring(chrootPath.length()));
}
```
Currently, chroot strip code listed above could result in illegal path
(aka. path not start with "/"). This will disconnect zookeeper client
due to `StringIndexOutOfBoundsException` from `PathParentIterator.next`
in event handling.
Author: Kezhu Wang <kezhuw@gmail.com>
Reviewers: Enrico Olivelli <eolivelli@apache.org>, Mate Szalay-Beko <symat@apache.org>
Closes apache#1899 from kezhuw/ZOOKEEPER-4565-refine-chroot-strip
This PR tries to fix several test failures in `RequestThrottlerTest`.
First, `RequestThrottlerTest#testDropStaleRequests`.
Place `Thread.sleep(200)` after `submittedRequests.take()` in `RequestThrottler#run` will fail two assertions:
1. `assertEquals(2L, (long) metrics.get("prep_processor_request_queued"))`
2. `assertEquals(1L, (long) metrics.get("request_throttle_wait_count"))`
This happens due to `setStale` chould happen before throttle handling.
This commit solves this by introducing an interception point `RequestThrottler.throttleSleep` to build happen-before relations:
1. `throttling.countDown` happens before `setStale`, this ensures that unthrottled request are processed as usual.
2. `setStale` happens before `throttled.await`, this defends `RequestThrottler.throttleSleep` against spurious wakeup.
Second, `RequestThrottlerTest#testRequestThrottler`.
* `RequestThrottlerTest.testRequestThrottler:197 expected: <2> but was: <1>`
`ZooKeeperServer#submitRequest` and `PrepRequestProcessor#processRequest` run in different threads, thus there is no guarantee on metric `prep_processor_request_queued` after `submitted.await(5, TimeUnit.SECONDS)`. Place `Thread.sleep(200)` before `zks.submitRequestNow(request)` in `RequestThrottler#run` will incur this failure.
* `RequestThrottlerTest.testRequestThrottler:206 expected: <5> but was: <4>`
`entered.await(STALL_TIME, TimeUnit.MILLISECONDS)` could return `false` due to almost same timeout as `RequestThrottler#throttleSleep`. Place `Thread.sleep(500)` around `throttleSleep` will increase failure possibility.
Third, `RequestThrottlerTest#testGlobalOutstandingRequestThrottlingWithRequestThrottlerDisabled`.
* `RequestThrottlerTest.testGlobalOutstandingRequestThrottlingWithRequestThrottlerDisabled:340 expected: <3> but was: <4>`
`ZooKeeperServer#shouldThrottle` depends on consistent sum of `getInflight` and `getInProcess`. But it is no true. Place `Thread.sleep(200)` before `zks.submitRequestNow(request)` in `RequestThrottler#run` could reproduce this.
Sees also apache#1739, apache#1821.
Author: Kezhu Wang <kezhuw@gmail.com>
Reviewers: Mate Szalay-Beko <symat@apache.org>, maoling <maoling@apache.org>
Closes apache#1887 from kezhuw/ZOOKEEPER-4327-flaky-RequestThrottlerTest.testDropStaleRequests
(cherry picked from commit bc1b231)
Signed-off-by: maoling <maoling@apache.org>
The current docker image `maven:3.6.3-jdk-8` has many critical security issues. maven3.6.3-jdk-8 › dpkg1.19.7 has [CVE-2022-1664](https://www.cve.org/CVERecord?id=CVE-2022-1664) maven3.6.3-jdk-8 › openssl1.1.1d-0+deb10u6 has [CVE-2021-3711](https://www.cve.org/CVERecord?id=CVE-2021-3711) maven3.6.3-jdk-8 › gzip1.9-3 has [CVE-2022-1271](https://www.cve.org/CVERecord?id=CVE-2022-1271) We need to upgrade the docker base image to version `maven:3.8.4-jdk-8` See [ZOOKEEPER-4616](https://issues.apache.org/jira/browse/ZOOKEEPER-4616) for full details. Author: chenhang <chenhang@apache.org> Reviewers: Enrico Olivelli <eolivelli@apache.org> Closes apache#1927 from hangc0276/chenhang/ZOOKEEPER-4616 (cherry picked from commit e2bc3dd) Signed-off-by: Enrico Olivelli <enrico.olivelli@datastax.com>
ZOOKEEPER-4460: QuorumPeer overrides Thread.getId with different sema… Signed-off-by: Enrico Olivelli <eolivelli@apache.org> (cherry picked from commit cedf093)
Author: Li Wang <liwang@apple.com> (cherry picked from commit 4ad0103)
Co-authored-by: Mike Dobozy <mdobozy@redhat.com> Co-authored-by: Anup Ghatage <ghatage@apache.org> Signed-off-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Mate Szalay-Beko <symat@apache.org> (cherry picked from commit 21a707b)
…e CVE errors (apache#2026) Our jackson is quite old, I want to upgrade it before release 3.8.2. Also we have a few false positive CVEs reported by OWASP: - CVE-2023-35116: according to jackson community, this is not a security issue, see FasterXML/jackson-databind#3972 (comment) - CVE-2022-45688: the following CVE is not even jackson related, but a vulnerability in json-java which we don't use in ZooKeeper (cherry picked from commit f91a1fc)
…2014) Address multiple CVEs: CVE-2023-34453 CVE-2023-34454 CVE-2023-34455 See https://github.com/xerial/snappy-java/releases/tag/v1.1.10.1 (cherry picked from commit 4661437)
(cherry picked from commit 004d679)
(cherry picked from commit 139d619)
(cherry picked from commit 6febd34)
Author: Andor Molnar <andor@apache.org> Reviewers: symat@apache.org Closes apache#2035 from anmolnar/ZOOKEEPER-4721 (cherry picked from commit 688c69c) Signed-off-by: Andor Molnar <andor@apache.org>
…IGEST-MD5 vs GSSAPI in quorum auth Before this, the SASL-based quorum authorizer did not explicitly distinguish between the DIGEST-MD5 and GSSAPI mechanisms: it was simply relying on NameCallback and PasswordCallback for authentication with the former and examining Kerberos principals in AuthorizeCallback for the latter. It turns out that some SASL/DIGEST-MD5 configurations cause authentication and authorization IDs not to match the expected format, and the DIGEST-MD5-based portions of the quorum test suite to fail with obscure errors. (They can be traced to failures to join the quorum, but only by looking into detailed logs.) This patch uses the login module name to determine whether DIGEST-MD5 or GSSAPI is used, and relaxes the authentication ID check for the former. As a cleanup, it keeps the password-based credential map empty when Kerberos principals are expected. It finally adapts a test, and adds a new one, ensuring "weirdly-shaped" credentials only cause authentication failures in the GSSAPI case.
snappy-java 1.1.10.1 contains CVE-2023-43642 . Upgrade the dependency to 1.1.10.5 to get rid of the CVE. see https://issues.apache.org/jira/browse/ZOOKEEPER-4751 Author: Lari Hotari <lari@hotari.net> Reviewers: Andor Molnar <andor@apache.org>, Damien Diederen <ddiederen@apache.org> Closes apache#2072 from lhotari/ZOOKEEPER-4751
… and CVE-2023-41900 The release notes of the newly referenced release: https://github.com/eclipse/jetty.project/releases/tag/jetty-9.4.52.v20230823 explicitly mention the three CVEs. Author: Damien Diederen <ddiederen@apache.org> Reviewers: tison <wander4096@gmail.com>, Andor Molnar <andor@apache.org> Closes apache#2074 from ztzg/ZOOKEEPER-4754-jetty-cves (cherry picked from commit a0aced9) Signed-off-by: Damien Diederen <ddiederen@apache.org>
…4586 CVE-2023-4586 looks like a real vulnerability in Netty, but no report or patch has been published so far. This has to be monitored and will probably have to be remediated. https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2023-4586 Relevant discussion and pointers: jeremylong/DependencyCheck#5912 (comment) Author: Damien Diederen <ddiederen@apache.org> Reviewers: Andor Molnar <andor@apache.org>, Damien Diederen <ddiederen@apache.org> Closes apache#2075 from ztzg/ZOOKEEPER-4755-netty-CVE-2023-4586 (cherry picked from commit 5f3b3d6) Signed-off-by: Damien Diederen <ddiederen@apache.org>
…r set flag (apache#2020) (apache#2080) Co-authored-by: Yan Zhao <horizonzy@apache.org>
…pache#2040) * ZOOKEEPER-4728: force to re-resolve hostname into IP when binding * ZOOKEEPER-4708: add test (cherry picked from commit 40aed41) Signed-off-by: Andor Molnar <andor@apache.org>
…d binary logic ZOOKEEPER-910: Use SelectionKey.isXYZ() methods instead of complicated binary logic Signed-off-by: tison <wander4096@gmail.com> Co-authored-by: Michi Mutsuzaki <michim@apache.org> Reviewers: kezhuw, anmolnar Author: tisonkun Closes apache#2063 from tisonkun/ZOOKEEPER-910 (cherry picked from commit 6c2d94d) Signed-off-by: Andor Molnar <andor@apache.org>
ZOOKEEPER-4756: Merge script should use GitHub api to merge pull requests Change-Id: I22ee835617fd96b540edd65191f6c83aae5365a9 Fix check status handling in merge_pr function Change-Id: I99844bfac98c90e9bb525cb8d3eae5a465a56629 Refactor JIRA ID extraction pattern Change-Id: I85a458eaac03b2a76edbc2ec923d56467503f900 Reviewers: tisonkun Author: szucsvillo Closes apache#2092 from szucsvillo/ZOOKEEPER-4756 (cherry picked from commit 32fb89c) Signed-off-by: Andor Molnar <andor@apache.org>
ZOOKEEPER-2590:exists() should check read ACL permission ZOOKEEPER-2590. Skip ACL check if znode is missing Reviewers: eolivelli Author: anmolnar Closes apache#2093 from anmolnar/ZOOKEEPER-2590 (cherry picked from commit ceebda9) Signed-off-by: Andor Molnar <andor@apache.org>
…pr function (apache#2095) Change-Id: I7c738b31b8f5991bc5f93118285c561c2a4719af Co-authored-by: Villő Szűcs <szucsvillo@cloudera.com> (cherry picked from commit 2445fe6) Signed-off-by: Andor Molnar <andor@apache.org>
…- doc update ZOOKEEPER-2590. Add docs to mention the new behavior Author: anmolnar Closes apache#2096 from anmolnar/ZOOKEEPER-2590_doc (cherry picked from commit 9e40464) Signed-off-by: Andor Molnar <andor@apache.org>
…bjects (apache#2128) (cherry picked from commit 16abb9c) Signed-off-by: Andor Molnar <andor@apache.org>
…he#2125) This is a (simple) backport of apache#2118 to branch-3.8. Co-authored-by: iv9eni <3kbjutpr@anonaddy.me> Co-authored-by: Aurélien Pupier <apupier@redhat.com>
… and 4lw dirs command (apache#2135) Author: Li Wang <liwang@apple.com>
As of today, it is impossible to diagnose which watch events are dropped because of ACLs. Let's centralize, systematize, and log the checks at the 'process()' site in the Netty and NIO connections. (These 'process()' methods contain some duplicated code, and should also be refactored at some point. This series does not change them.) This patch also adds a substantial number of tests in order to avoid unexpected regressions. Co-authored-by: Patrick Hunt <phunt@apache.org> Co-authored-by: Damien Diederen <ddiederen@apache.org>
Contributor
|
This is not allowed in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
25 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a new branch
li-dev/base-3.8.4from the release tag 3.8.4.