Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2815: 1. Using try clause to close resource; 2. Others code refactoring for PERSISTENCE module #283

Closed
wants to merge 1 commit into from

Conversation

@asdf2014
Copy link
Member

commented Jun 16, 2017

MINOR:

  • Using try clause to close resource;
  • Others code refactoring for PERSISTENCE module.

@asdf2014 asdf2014 force-pushed the asdf2014:code_refactoring branch 6 times, most recently from 9a07f06 to a1fd118 Jun 16, 2017

@asdf2014 asdf2014 force-pushed the asdf2014:code_refactoring branch from a1fd118 to 713268d Jun 19, 2017

@asdf2014 asdf2014 changed the title MINOR: 1. Fix streamsToFlush not completely empty problem; 2. Using try clause to close resource; 3. Others code refactoring for PERSISTENCE module MINOR: 1. Using try clause to close resource; 2. Others code refactoring for PERSISTENCE module Jun 19, 2017

@hanm

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2017

@asdf2014 : Thanks for spending time refactoring the code base.

Please first file a JIRA and then make a pull request with the JIRA number in the PR title or description. We requires this so the changes can be tracked and kept records on Apache side. Please also checkout https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute.

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2017

Hi, @hanm . I got it and i will create the jira. Sorry for bring the MINOR habit from Apache Eagle..

@asdf2014 asdf2014 changed the title MINOR: 1. Using try clause to close resource; 2. Others code refactoring for PERSISTENCE module ZOOKEEPER-2815: 1. Using try clause to close resource; 2. Others code refactoring for PERSISTENCE module Jun 22, 2017

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2017

@hanm Already done.

@hanm

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2017

LGTM.

@asfgit asfgit closed this in 8ec4c58 Jun 25, 2017

asfgit pushed a commit that referenced this pull request Jun 25, 2017

ZOOKEEPER-2815: 1. Using try clause to close resource; 2. Others code…
… refactoring for PERSISTENCE module

MINOR:
* Using try clause to close resource;
* Others code refactoring for PERSISTENCE module.

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes #283 from asdf2014/code_refactoring

(cherry picked from commit 8ec4c58)
Signed-off-by: Michael Han <hanm@apache.org>
@hanm

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2017

Merged, thanks @asdf2014.

@asdf2014

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2017

@hanm You are welcome :D

@asdf2014 asdf2014 deleted the asdf2014:code_refactoring branch Jun 26, 2017

lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018

ZOOKEEPER-2815: 1. Using try clause to close resource; 2. Others code…
… refactoring for PERSISTENCE module

MINOR:
* Using try clause to close resource;
* Others code refactoring for PERSISTENCE module.

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes apache#283 from asdf2014/code_refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.