New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module #288

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@asdf2014
Member

asdf2014 commented Jun 20, 2017

  • Fix spell issues
  • Merge exceptions with | character
  • Remove unnecessary boxing
  • Remove unused import
  • Using enhanced for loop
  • Using LinkedList for removing duplicates ACL

@asdf2014 asdf2014 force-pushed the asdf2014:zk_quorum branch 3 times, most recently from 3a68d19 to 0fd948a Jun 20, 2017

@asdf2014 asdf2014 force-pushed the asdf2014:zk_quorum branch from 0fd948a to cf7f72a Jun 21, 2017

@hanm

This comment has been minimized.

Contributor

hanm commented Jun 21, 2017

Please create a JIRA issue for this one too - see my comment on #283.

@asdf2014 asdf2014 changed the title from MINOR: Code refactoring for `ZK_SERVER` module to ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module Jun 22, 2017

@asdf2014

This comment has been minimized.

Member

asdf2014 commented Jun 22, 2017

@hanm Already done.

@hanm

This comment has been minimized.

Contributor

hanm commented Jun 25, 2017

LGTM.

@asfgit asfgit closed this in a0eba7a Jun 25, 2017

asfgit pushed a commit that referenced this pull request Jun 25, 2017

ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exceptions with `|` character
* Remove unnecessary boxing
* Remove unused import
* Using enhanced `for` loop
* Using `LinkedList` for removing duplicates ACL

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes #288 from asdf2014/zk_quorum

(cherry picked from commit a0eba7a)
Signed-off-by: Michael Han <hanm@apache.org>

@asdf2014 asdf2014 deleted the asdf2014:zk_quorum branch Jun 26, 2017

hanm added a commit to hanm/zookeeper that referenced this pull request Jul 2, 2017

ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exceptions with `|` character
* Remove unnecessary boxing
* Remove unused import
* Using enhanced `for` loop
* Using `LinkedList` for removing duplicates ACL

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes apache#288 from asdf2014/zk_quorum

hanm added a commit to hanm/zookeeper that referenced this pull request Jul 2, 2017

ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exceptions with `|` character
* Remove unnecessary boxing
* Remove unused import
* Using enhanced `for` loop
* Using `LinkedList` for removing duplicates ACL

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes apache#288 from asdf2014/zk_quorum

lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018

ZOOKEEPER-2816: Code refactoring for `ZK_SERVER` module
* Fix spell issues
* Merge exceptions with `|` character
* Remove unnecessary boxing
* Remove unused import
* Using enhanced `for` loop
* Using `LinkedList` for removing duplicates ACL

Author: asdf2014 <1571805553@qq.com>

Reviewers: Michael Han <hanm@apache.org>

Closes apache#288 from asdf2014/zk_quorum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment