Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2826: Code refactoring for CLI module #298

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-2826: Code refactoring for CLI module #298

wants to merge 1 commit into from

Conversation

@asdf2014
Copy link
Member

@asdf2014 asdf2014 commented Jun 29, 2017

  • Fix spell issues
  • Remove unnecessary import
  • Make initialization block that related with options.addOption into static
  • Standardize StringBuilder#append usage
  • Using try clause to release the resource of stream
@@ -52,12 +52,12 @@
private String members;

/* version - version of config from which we want to reconfigure - if current config is different
* reconfiguration will fail. Should be ommitted from the CLI to disable this option.
* reconfiguration will fail. Should be committed from the CLI to disable this option.

This comment has been minimized.

@maoling

maoling Aug 8, 2017
Member

is it right?

This comment has been minimized.

@asdf2014

asdf2014 Aug 8, 2017
Author Member

@maoling Thank you for the comment. Yep, ommitted should be changed into committed.

@anmolnar
Copy link
Contributor

@anmolnar anmolnar commented Jan 30, 2019

@asdf2014 Are u still willing to work on this patch?

@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Jan 31, 2019

@anmolnar Yep, I will work on it later.

* Remove unnecessary `import`

* Make initialization block that related with `options.addOption` into static

* Standardize `StringBuilder#append` usage

* Using `try` clause to release the resource of stream
@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Jan 31, 2019

@anmolnar Done.

@asfgit asfgit closed this in 8f62ee9 Jan 31, 2019
asfgit pushed a commit that referenced this pull request Jan 31, 2019
* Fix spell issues
* Remove unnecessary `import`
* Make initialization block that related with `options.addOption` into static
* Standardize `StringBuilder#append` usage
* Using `try` clause to release the resource of stream

Author: asdf2014 <benedictjin2016@gmail.com>

Reviewers: andor@apache.org

Closes #298 from asdf2014/ZOOKEEPER-2826

(cherry picked from commit 8f62ee9)
Signed-off-by: Andor Molnar <andor@apache.org>
@anmolnar
Copy link
Contributor

@anmolnar anmolnar commented Jan 31, 2019

Merged to 3.5 and master branches. Thanks @asdf2014 !

@asdf2014 asdf2014 deleted the asdf2014:ZOOKEEPER-2826 branch Feb 1, 2019
@asdf2014
Copy link
Member Author

@asdf2014 asdf2014 commented Feb 1, 2019

@anmolnar You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants