/zookeeper

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2826: Code refactoring for `CLI` module #298

Open
wants to merge 1 commit into
base: master
from

Conversation

Reviewers

@maoling maoling

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asdf2014 @maoling
@asdf2014
Member

asdf2014 commented Jun 29, 2017

  • Fix spell issues
  • Remove unnecessary import
  • Make initialization block that related with options.addOption into static
  • Standardize StringBuilder#append usage
  • Using try clause to release the resource of stream
@maoling

maoling reviewed Aug 8, 2017
View changes

src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java
@@ -52,12 +52,12 @@
private String members;

/* version - version of config from which we want to reconfigure - if current config is different
* reconfiguration will fail. Should be ommitted from the CLI to disable this option.
* reconfiguration will fail. Should be committed from the CLI to disable this option.

This comment has been minimized.

Sign in to view
Copy link
@maoling

maoling Aug 8, 2017

Contributor

is it right?

This comment has been minimized.

Sign in to view
Copy link
@asdf2014

asdf2014 Aug 8, 2017

Member

@maoling Thank you for the comment. Yep, ommitted should be changed into committed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment