ZOOKEEPER-2826: Code refactoring for CLI module
#298
Closed
Conversation
| @@ -52,12 +52,12 @@ | |||
| private String members; | |||
|
|
|||
| /* version - version of config from which we want to reconfigure - if current config is different | |||
| * reconfiguration will fail. Should be ommitted from the CLI to disable this option. | |||
| * reconfiguration will fail. Should be committed from the CLI to disable this option. | |||
maoling
Aug 8, 2017
Member
is it right?
is it right?
|
@asdf2014 Are u still willing to work on this patch? |
|
@anmolnar Yep, I will work on it later. |
* Remove unnecessary `import` * Make initialization block that related with `options.addOption` into static * Standardize `StringBuilder#append` usage * Using `try` clause to release the resource of stream
|
@anmolnar Done. |
asfgit
pushed a commit
that referenced
this pull request
Jan 31, 2019
* Fix spell issues * Remove unnecessary `import` * Make initialization block that related with `options.addOption` into static * Standardize `StringBuilder#append` usage * Using `try` clause to release the resource of stream Author: asdf2014 <benedictjin2016@gmail.com> Reviewers: andor@apache.org Closes #298 from asdf2014/ZOOKEEPER-2826 (cherry picked from commit 8f62ee9) Signed-off-by: Andor Molnar <andor@apache.org>
|
Merged to 3.5 and master branches. Thanks @asdf2014 ! |
|
@anmolnar You are welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
importoptions.addOptioninto staticStringBuilder#appendusagetryclause to release the resource of stream