Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
branch-3.4 -- bugfix -- ZOOKEEPER-2894 #363
Hi @xoiss please update this PR to follow the guidelines in "generate a pull request" here: https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute - in particular wrt the summary and description text which really helps folks identifying which PRs to prioritize. Thanks!
Ok... As I remember, it turned out there is bug in the fix proposed by me here in case of multi-threaded build. So, it remedies the single-threaded build, but breaks the multi-threaded.
The cause is the 'assert' in the else part. I don't remember what was the idea to put it in the else part... to guarantee what. Surely, the else part never happens in the single-threaded version. But, it occurs in 100% of cases in the multi-threaded, and process gets SIGABRT. As soon as I've been using only the single-treaded version those times, I did not notice that in September 2017. We noticed it later with the different project that uses multi-threaded.
Ok, we have already debugged this and refixed in our locally patched fork, but I have not updated this request here.
So, I need to rework and rebase.
The improved issue: https://issues.apache.org/jira/browse/ZOOKEEPER-2894
The renewed PR: #1000
So, I hope now it comply with the PR-style.
Please, revise my renewed PR: #1000