Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fake host names to avoid test failures #48

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@timothyjward
Copy link
Contributor

commented Dec 8, 2015

Some of the ZooKeeper tests use "fake" hostnames to trigger host resolution failures. The problem with this is that it uses valid hostnames which are sometimes configured in VMs.

At the moment I am unable to build cleanly because I get test failures on the two test methods that do this. The tests work equally well if syntactically invalid hostnames are used, and the test cases become more portable at the same time.

@cnauroth

This comment has been minimized.

Copy link
Contributor

commented Dec 10, 2015

Hi @timothyjward . Thank you for the patch. I have committed this, tracked in Apache JIRA ZOOKEEPER-2252. Could you please close this pull request?

@timothyjward

This comment has been minimized.

Copy link
Contributor Author

commented Dec 11, 2015

Closing as the patch has been applied via Apache SVN/JIRA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.