Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2955: Enable Clover code coverage report #519

Closed
wants to merge 1 commit into from

Conversation

@nkalmar
Copy link
Contributor

nkalmar commented May 11, 2018

ZOOKEEPER-2955: Enable Clover code coverage report

This PR configures OpenClover to generate Java code coverage reports.

To generate Java code coverage report run:
ant test-coverage-clover-java

For quick testing of this PR run:
ant -Dtestcase=test_file_name test-coverage-clover-java

Clover can also be run step-by-step:
ant -Drun.clover=true test-core-java
ant clover-report

Note: run.clover must not be set when building ZK for production use.

The reports will be placed under the build/test/clover/reports directory in HTML and XML formats.

Author: Mark Fenes mfenes@cloudera.com

Reviewers: phunt@apache.org

Closes #443 from mfenes/ZOOKEEPER-2955 and squashes the following commits:

321fc01 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
ca68181 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
4cd1a31 [Mark Fenes] Trigger notification
09872a6 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
3e0f254 [Mark Fenes] Trigger notification
0cdb444 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
270c12e [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
f59dcf8 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report

Change-Id: I089ca39224fa6012a299a46e4a35333ecc87ef35

@nkalmar

This comment has been minimized.

Copy link
Contributor Author

nkalmar commented May 11, 2018

This is the updated PR for the Clover code coverage. Previous PR for branch 3.4 and 3.5 were not updated, so I cherry picked the complete change from master.

@nkalmar nkalmar force-pushed the nkalmar:branch-3.5 branch 4 times, most recently from bb2cbda to 411a649 May 11, 2018
ZOOKEEPER-2955: Enable Clover code coverage report

This PR configures OpenClover to generate Java code coverage reports.

To generate Java code coverage report run:
ant test-coverage-clover-java

For quick testing of this PR run:
ant -Dtestcase=test_file_name test-coverage-clover-java

Clover can also be run step-by-step:
ant -Drun.clover=true test-core-java
ant clover-report

Note: run.clover must not be set when building ZK for production use.

The reports will be placed under the build/test/clover/reports directory in HTML and XML formats.

Author: Mark Fenes <mfenes@cloudera.com>

Reviewers: phunt@apache.org

Closes #443 from mfenes/ZOOKEEPER-2955 and squashes the following commits:

321fc01 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
ca68181 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
4cd1a31 [Mark Fenes] Trigger notification
09872a6 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
3e0f254 [Mark Fenes] Trigger notification
0cdb444 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
270c12e [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
f59dcf8 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report

Change-Id: I089ca39224fa6012a299a46e4a35333ecc87ef35
@nkalmar nkalmar force-pushed the nkalmar:branch-3.5 branch from 411a649 to 63ea347 May 11, 2018
Copy link
Contributor

anmolnar left a comment

+1 lgtm, thanks!

asfgit pushed a commit that referenced this pull request May 20, 2018
ZOOKEEPER-2955: Enable Clover code coverage report

This PR configures OpenClover to generate Java code coverage reports.

To generate Java code coverage report run:
ant test-coverage-clover-java

For quick testing of this PR run:
ant -Dtestcase=test_file_name test-coverage-clover-java

Clover can also be run step-by-step:
ant -Drun.clover=true test-core-java
ant clover-report

Note: run.clover must not be set when building ZK for production use.

The reports will be placed under the build/test/clover/reports directory in HTML and XML formats.

Author: Mark Fenes <mfenescloudera.com>

Reviewers: phuntapache.org

Closes #443 from mfenes/ZOOKEEPER-2955 and squashes the following commits:

321fc01 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
ca68181 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
4cd1a31 [Mark Fenes] Trigger notification
09872a6 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
3e0f254 [Mark Fenes] Trigger notification
0cdb444 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
270c12e [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report
f59dcf8 [Mark Fenes] ZOOKEEPER-2955: Enable Clover code coverage report

Change-Id: I089ca39224fa6012a299a46e4a35333ecc87ef35

Author: Mark Fenes <mfenes@cloudera.com>

Reviewers: phunt@apache.org

Closes #519 from nkalmar/branch-3.5
@phunt

This comment has been minimized.

Copy link
Contributor

phunt commented May 20, 2018

+1, please close this PR manually

@nkalmar nkalmar closed this May 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.