ZOOKEEPER-1990 - fix Random instances #617
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maoling
approved these changes
Sep 9, 2018
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2018
See the jira for more info. Basically we have multiple ways of creating Random instances in ZooKeeper. Since java 1.7, the default constructor is good enough even in multi-threaded environment, we get a good seed. But in some places, we just create a random instance, where System.nanotime is the seed, which is not a good practice in multi-threaded environments. I only replaced those, and I also left the tests as is, because in some cases it is intentional in them. I created the PR to bring more attention to the ticket, please feel free to share your ideas on the topic! Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: fangmin@apache.org, andor@apache.org Closes #617 from nkalmar/ZOOKEEPER-1990 (cherry picked from commit 181de25) Signed-off-by: Andor Molnar <andor@apache.org>
|
Committed to branch-3.5 and master. |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
See the jira for more info. Basically we have multiple ways of creating Random instances in ZooKeeper. Since java 1.7, the default constructor is good enough even in multi-threaded environment, we get a good seed. But in some places, we just create a random instance, where System.nanotime is the seed, which is not a good practice in multi-threaded environments. I only replaced those, and I also left the tests as is, because in some cases it is intentional in them. I created the PR to bring more attention to the ticket, please feel free to share your ideas on the topic! Author: Norbert Kalmar <nkalmar@yahoo.com> Reviewers: fangmin@apache.org, andor@apache.org Closes apache#617 from nkalmar/ZOOKEEPER-1990
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the jira for more info.
Basically we have multiple ways of creating Random instances in ZooKeeper. Since java 1.7, the default constructor is good enough even in multi-threaded environment, we get a good seed.
But in some places, we just create a random instance, where System.nanotime is the seed, which is not a good practice in multi-threaded environments.
I only replaced those, and I also left the tests as is, because in some cases it is intentional in them.
I created the PR to bring more attention to the ticket, please feel free to share your ideas on the topic!