Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-2617: correct a few spelling typos #87

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-2617: correct a few spelling typos #87

wants to merge 1 commit into from

Conversation

tmancill
Copy link

Hi - this PR contains corrections for some spelling typos. Most of them appear in comments, but a few appear in documentation and program output. Thank you for considering it.

@fpj
Copy link
Contributor

fpj commented Oct 17, 2016

hi @tmancill, thanks for contributing. we need a jira issue associated to this, check the guidelines here, please:

https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute

@tmancill
Copy link
Author

Hello @fpj . Thank you for the the pointer to contribution guidelines. I have submitted JIRA ZOOKEEPER-2617 and attached the patch there.

@eribeiro
Copy link
Contributor

Hi @tmancill,

Nice path! LGTM. 👍

Would you mind to update the title of the PR to be "ZOOKEEPER-2617: correct a few spelling typos"? AFAIK, we need this bridge the JIRA and the Github, even tough I don't know if it will work when the PR is created before the JIRA. Even so, we can give it a try.

@tmancill tmancill changed the title correct a few spelling typos ZOOKEEPER-2617: correct a few spelling typos Oct 25, 2016
@tmancill
Copy link
Author

Hi @eribeiro - title updated. Thank you for considering the patch.

@fpj
Copy link
Contributor

fpj commented Oct 25, 2016

+1 lgtm. Thanks for the patch, @tmancill.

@eribeiro
Copy link
Contributor

Hi @fpj, could we have this PR merged? :)

Thanks!

PS: It is target at branch-3.4, but would be cool if we could also apply it to branch-3.5 and master.

@eribeiro
Copy link
Contributor

Hi @rakeshadr, this is another possible candidate for 3.4.10 release, in my humble opinion. Flávio gave his blessing and the branch doesn't conflict with branch-3.4.

PS: I didn't cherry-pick this into branch-3.5 and master so I don't know if it has any conflicts with those branches, but it would be nice to have it ported to them too.

Cheers!

@rakeshadr
Copy link
Contributor

@eribeiro sure, I will consider this to 3.4.10. Thanks @tmancill for the contribution. Sorry for the delay in looking at this jira, could you please create separate PR for {{master}} branch as the current PR_87 is not applying to {{branch-3.5}} and {{master}}.

@rakeshadr
Copy link
Contributor

I'm merging this to branch-3.4.
Could you provide another PR for master/branch3.5 as this has minor conflicts and not applying properly. Thanks!

asfgit pushed a commit that referenced this pull request Feb 13, 2017
@tmancill @rakeshadr
ZOOKEEPER-2617: correct a few spelling typos
e51dbeb 
Hi - this PR contains corrections for some spelling typos.  Most of them appear in comments, but a few appear in documentation and program output.  Thank you for considering it.

Author: tony mancill <tmancill@debian.org>

Reviewers: Flavio Junqueira <fpj@apache.org>, Edward Ribeiro <edward.ribeiro@gmail.com>, Rakesh Radhakrishnan <rakeshr@apache.org>

Closes #87 from tmancill/tmancill/spelling-typos
@rakeshadr
Copy link
Contributor

Please close this PR as this is merged, thanks!

@eribeiro eribeiro mentioned this pull request Feb 13, 2017
Closed
asfgit pushed a commit that referenced this pull request Feb 14, 2017
@eribeiro @rakeshadr
ZOOKEEPER-2617: correct a few spelling typos
0816970 
Hi - this PR contains corrections for some spelling typos.  Most of them appear in comments, but a few appear in documentation and program output.  Thank you for considering it.

Author: tony mancill <tmancilldebian.org>

Reviewers: Flavio Junqueira <fpjapache.org>, Edward Ribeiro <edward.ribeirogmail.com>, Rakesh Radhakrishnan <rakeshrapache.org>

Closes #87 from tmancill/tmancill/spelling-typos

Author: Edward Ribeiro <edward.ribeiro@gmail.com>

Reviewers: Rakesh Radhakrishnan <rakeshr@apache.org>

Closes #174 from eribeiro/ZOOKEEPER-2617
@asfgit asfgit closed this in 15e3f7f Feb 14, 2017
lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018
@eribeiro
ZOOKEEPER-2617: correct a few spelling typos
4788a06 
Hi - this PR contains corrections for some spelling typos.  Most of them appear in comments, but a few appear in documentation and program output.  Thank you for considering it.

Author: tony mancill <tmancilldebian.org>

Reviewers: Flavio Junqueira <fpjapache.org>, Edward Ribeiro <edward.ribeirogmail.com>, Rakesh Radhakrishnan <rakeshrapache.org>

Closes apache#87 from tmancill/tmancill/spelling-typos

Author: Edward Ribeiro <edward.ribeiro@gmail.com>

Reviewers: Rakesh Radhakrishnan <rakeshr@apache.org>

Closes apache#174 from eribeiro/ZOOKEEPER-2617

(cherry picked from commit 0816970)
Signed-off-by: Rakesh Radhakrishnan <rakeshr@apache.org>
mgao0 added a commit to mgao0/zookeeper that referenced this pull request Aug 17, 2022
@mgao0
Add an optional feature to add both clientId and domain name to authI…
2288709 
…nfo (apache#87)

This commit adds an optional feature to be configured by key "zookeeper.X509ZNodeGroupAclProvider.storeAuthedClientId". If enabled, the server will store the clientId in authInfo, in addition to the matched domain name(s). This feature is only available in non-dedicated server cases.

Added test: X509ZNodeGroupAclProviderTest.testStoreAuthedClientId
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@eribeiro @RokLenarcic
ZOOKEEPER-2617: correct a few spelling typos
5ae54bd 
Hi - this PR contains corrections for some spelling typos.  Most of them appear in comments, but a few appear in documentation and program output.  Thank you for considering it.

Author: tony mancill <tmancilldebian.org>

Reviewers: Flavio Junqueira <fpjapache.org>, Edward Ribeiro <edward.ribeirogmail.com>, Rakesh Radhakrishnan <rakeshrapache.org>

Closes apache#87 from tmancill/tmancill/spelling-typos

Author: Edward Ribeiro <edward.ribeiro@gmail.com>

Reviewers: Rakesh Radhakrishnan <rakeshr@apache.org>

Closes apache#174 from eribeiro/ZOOKEEPER-2617

(cherry picked from commit 0816970)
Signed-off-by: Rakesh Radhakrishnan <rakeshr@apache.org>
mgao0 added a commit to mgao0/zookeeper that referenced this pull request Dec 8, 2022
@mgao0
Add entry point for setting StoreAuthedClientId config property (apac…
2ae6587 
…he#94)

In apache#87, one entry point for setting the config value is missing. This commit adds the entry point in QuorumPeerConfig.

All znode group acl tests passed.
Will validate the config loading manually by deploying zk server with StoreAuthedClientId enabled in zk config.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tmancill @fpj @eribeiro @rakeshadr