Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing #95

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@fpj
Copy link
Contributor

fpj commented Oct 28, 2016

No description provided.

fpj added some commits Oct 28, 2016

@arshadmohammad

This comment has been minimized.

Copy link
Contributor

arshadmohammad commented Jan 27, 2017

LGTM, I will commit it.
@eribeiro do you have any comment?

@eribeiro

This comment has been minimized.

Copy link
Contributor

eribeiro commented Jan 27, 2017

Go ahead @arshadmohammad! 😃

My only observation is that this dead code is also in branch-3.4 and branch-3.5 so I would advise to cherry-pick it to those branches too, right @fpj ?

@asfgit asfgit closed this in edf75b5 Jan 28, 2017

asfgit pushed a commit that referenced this pull request Jan 28, 2017

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
Author: fpj <fpj@apache.org>

Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>

Closes #95 from fpj/ZK-2622

(cherry picked from commit edf75b5)
Signed-off-by: arshad <arshad@apache.org>

asfgit pushed a commit that referenced this pull request Jan 28, 2017

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
Author: fpj <fpj@apache.org>

Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>

Closes #95 from fpj/ZK-2622

(cherry picked from commit edf75b5)
Signed-off-by: arshad <arshad@apache.org>

lvfangmin pushed a commit to lvfangmin/zookeeper that referenced this pull request Jun 17, 2018

ZOOKEEPER-2622: ZooTrace.logQuorumPacket does nothing
Author: fpj <fpj@apache.org>

Reviewers: Edward Ribeiro <edward.ribeiro@gmail.com>

Closes apache#95 from fpj/ZK-2622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.