Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix MacOS/BSD, misc #1

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

ttilley commented Feb 22, 2012

  • fix compilation on MacOS, FreeBSD, and OpenBSD
  • gitignore .o and .a files
  • use local paths in makefile

The header fix is pulled from Mongrel2.

Owner

apankrat commented Feb 23, 2012

Travis,

thanks for the patch.

With regards to the header fix - I passionately hate ifdefs in the code, especially for conditional includes. For larger projects this should be handled at the Makefile level by altering the include paths. For smaller stuff, like halloc, I'd rather include a more generic header (stdlib.h) than to pollute the code with ifdefs.

With regards to gitignore - this is version control specific stuff, it doesn't really belong in the source code package. There are basically two views of this - some people think it's ok to mix version control info with the source code (whether it's adding .gitxx files to the source tree or CVS revisions to the source files themselves), and there are those who like their flies separate from their soup :) I am of a latter school, the git ignore list needs to be configured globally.

/usr/local - ok, my bad

It is easy

Owner

apankrat commented Aug 1, 2014

Better late than never. Switched to /usr/local/ - d7f656f

@apankrat apankrat closed this Aug 1, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment