Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not working for Ubiquity devices #26

Closed
FreifunkUFO opened this issue Aug 9, 2017 · 8 comments
Closed

not working for Ubiquity devices #26

FreifunkUFO opened this issue Aug 9, 2017 · 8 comments

Comments

@FreifunkUFO
Copy link
Contributor

there is an error when trying it with UBNT devices: board not found

@FreifunkUFO
Copy link
Contributor Author

f.i. board-name is "loco-m-xw", but imagebuilder wants "ubnt-loco-m-xw".

root@74-57:~# ubus call system board {
"kernel": "4.4.79",
"hostname": "74-57",
"system": "Atheros AR9342 rev 2",
"model": "Ubiquiti Loco M XW",
"board_name": "loco-m-xw",

so please check LEDE (maybe a new ticket there?) and write a workaround.
f.i. with an "if model=Ubiquity"-question and modified subfunction:

function image_request() {
console.log("image_request")
request_dict = {}
request_dict.version = latest_version;
request_dict.board = "ubnt-" + data.board_name
server_request(request_dict, "image-request", image_request_handler)
}

deeplink: https://github.com/openwrt/luci/blob/master/applications/luci-app-attendedsysupgrade/luasrc/view/attendedsysupgrade.htm#L180

@FreifunkUFO
Copy link
Contributor Author

att-wizawrd3

@aparcar
Copy link
Member

aparcar commented Aug 9, 2017

thanks for the testing, seems like the imagebuilder calls the image ubnt-loco-m-xw while the board_info contains loco-m-xw. I'll have to ask the lede project why the ubnt- part is missing
@dangowrt ideas?

@FreifunkUFO
Copy link
Contributor Author

is it only happening for ubnt-devices?
what about a workaround? (with an "if model=Ubiquity"-question and modified subfunction (+=ubnt))

@dangowrt
Copy link
Member

dangowrt commented Aug 10, 2017 via email

@aparcar aparcar added the gsoc label Aug 10, 2017
aparcar added a commit to aparcar/luci that referenced this issue Aug 10, 2017
as reported [here][1] the board_name is not everywhere unified yet. to
solve this problem, the model name is transported as well and used as a
fallback identifier

[1]: openwrt/asu#26

Signed-off-by: Paul Spooren <paul@spooren.de>
@aparcar
Copy link
Member

aparcar commented Aug 10, 2017

 id  | distro | release  | target | subtarget |         profile         | model                
 281 | lede   | snapshot | ar71xx | generic   | ubnt-loco-m-xw          | Ubiquiti Loco XW

"model": "Ubiquiti Loco M XW",
"board_name": "loco-m-xw",

The ImageBuilder uses a different model string and a different profile string as stored on the device. Looks like I have to work with (SQL) regex after all.

@dangowrt @FreifunkUFO other ideas to solve this in a more generic way?

aparcar added a commit that referenced this issue Aug 10, 2017
Signed-off-by: Paul Spooren <paul@spooren.de>
@aparcar aparcar closed this as completed Aug 10, 2017
@dangowrt
Copy link
Member

dangowrt commented Aug 11, 2017 via email

aparcar added a commit to aparcar/luci that referenced this issue Aug 13, 2017
as reported [here][1] the board_name is not everywhere unified yet. to
solve this problem, the model name is transported as well and used as a
fallback identifier

[1]: openwrt/asu#26

Signed-off-by: Paul Spooren <paul@spooren.de>
@FreifunkUFO
Copy link
Contributor Author

ticket was closed. but please link the filed bug at lede-project about board_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants