Skip to content

Correction exists #299

Merged
merged 2 commits into from Jun 9, 2013

2 participants

@dblugeon
dblugeon commented Jun 9, 2013

Hello,
The original problem can occur with custom ids. Specialy with ids wich contains characters must be url encoded. For example an url.
To reproduce this issue follow the following steps

c = ES('localhost:9200')
myDoc = { "field" : "content"}
c.index(myDoc, 'myindex', 'mydoctype', id='http://example.com')
c.get('myindex', 'mydoctype', 'http://example.com')
#return the object
c.exists('myindex', 'mydoctype', 'http://example.com')
#in the latest version return false with pies 0.20.
dblugeon added some commits Jun 9, 2013
@dblugeon dblugeon Correction for exists method.
Now, it responds that a doc exists when id contains characters to url encode. Like as the get method.
2bf96c2
@dblugeon dblugeon adding a test for exists method 56aa949
@aparo aparo merged commit cb9422b into aparo:master Jun 9, 2013
@aparo
Owner
aparo commented Jun 9, 2013

Good catch.
Thanks for contributing.

@dblugeon dblugeon deleted the dblugeon:correction-exists branch Jun 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.