Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis, MySQL and testing fixes #242

Merged
merged 4 commits into from
May 25, 2021
Merged

Travis, MySQL and testing fixes #242

merged 4 commits into from
May 25, 2021

Conversation

tofu-rocketry
Copy link
Member

@tofu-rocketry tofu-rocketry commented May 25, 2021 •
edited
Loading

  • Changes to Travis file bring our APEL CI into line with SSM (which was updated more recently).
  • MySQL testing has been changed to use MariaDB defaults from 10.1.x as 10.2.x defaults don't work with the current schemas.
  • Some fixes to the client schema required by non-ancient versions of MySQL (or just typos).

Lack of update script recorded in #243

@tofu-rocketry
Update Travis build
9c8fb26
@tofu-rocketry
Set sql_mode to MariaDB 10.1 defaults
26a648a 
These is the sql_mode used in production. The schmeas don't work with
the later 10.2.x defaults currently.
@tofu-rocketry
Correct capitalisation of column name
73eac96
@tofu-rocketry
Change the default for LrmsId in client schema
83d6aaa 
Versions of MySQL that aren't ancient don't allow null in primary keys,
so this changes the default for LrmsId from NULL to empty string.
@tofu-rocketry tofu-rocketry added this to the 2.0.0 milestone May 25, 2021
@tofu-rocketry tofu-rocketry self-assigned this May 25, 2021
@tofu-rocketry tofu-rocketry requested a review from a team as a code owner May 25, 2021 13:24
@tofu-rocketry tofu-rocketry mentioned this pull request May 25, 2021
Closed
@tofu-rocketry tofu-rocketry modified the milestones: 2.0.0, 1.9.1 May 25, 2021
gregcorbett
gregcorbett approved these changes May 25, 2021
View reviewed changes
Copy link
Member

@gregcorbett gregcorbett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@tofu-rocketry tofu-rocketry merged commit 42a2c59 into apel:dev May 25, 2021
@tofu-rocketry tofu-rocketry deleted the mysql-test-fix branch May 25, 2021 13:39
@tofu-rocketry tofu-rocketry modified the milestones: 1.10.0, 1.9.1 Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregcorbett gregcorbett gregcorbett approved these changes

Assignees

@tofu-rocketry tofu-rocketry

Labels
bug
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tofu-rocketry @gregcorbett