Skip to content
Commits on Jan 25, 2010
  1. cmd-midx: some performance optimizations.

    Approximately doubles the speed of generating indexes.
    committed Jan 25, 2010
  2. cmd-midx: add --auto and --force options.

    Rather than having to list the indexes you want to merge, now it can do it
    for you automatically.  The output filename is now also optional; it'll
    generate it in the right place in the git repo automatically.
    committed Jan 25, 2010
  3. When there are multiple overlapping .midx files, discard redundant ones.

    That way if someone generates a .midx for a subset of .idx files, then
    another for the *entire* set of .idx files, we'll automatically ignore the
    former one, thus increasing search speed and improving memory thrashing
    behaviour even further.
    committed Jan 25, 2010
  4. MultiPackIndex: use .midx files if they exist.

    Wow, using a single .midx file that merges my 435 megs of packfile indexes
    (across 169 files) reduces memory churn in memtest.py by at least two orders
    of magnitude.  (ie. we need to map 100x fewer memory pages in order to
    search for each nonexistent object when creating a new backup)  memtest.py
    runs *visibly* faster.
    
    We can also remove the PackBitmap code now, since it's not nearly as good as
    the PackMidx stuff and is now an unnecessary layer of indirection.
    committed Jan 25, 2010
  5. cmd-midx: a command for merging multiple .idx files into one.

    This introduces a new "multi-index" index format, as suggested by Lukasz
    Kosewski.
    
    .midx files have a variable-bit-width fanout table that's supposedly
    optimized to be able to find any sha1 while dirtying only two pages (one for
    the fanout table lookup, and one for the final binary search).  Each entry
    in the fanout table should correspond to approximately one page's worth of
    sha1sums.
    
    Also adds a PackMidx class, which acts just like PackIndex, but for .midx
    files.  Not using it for anything yet, though.  The idea is to greatly
    reduce memory burn when searching through lots of pack files.
    committed Jan 25, 2010
  6. Rename chashsplit.so to _hashsplit.so.

    Looks like the python standard is _modulename.so when making a C helper for
    a module named modulename.py, so let's do it that way.
    
    Also get rid of the annoying "module" suffix in the .c's filename.  Not sure
    why I ever thought that was needed.
    committed Jan 24, 2010
  7. @dcoombs
Commits on Jan 24, 2010
  1. toplevel exit() doesn't work in python 2.4.

    Use sys.exit() instead.
    committed Jan 24, 2010
  2. In some versions of python, comparing buffers with < gives a warning.

    It seems to be a buggy warning.  But we only really do it in one place, and
    buffers in question are only 20 bytes long, so forcing them into strings
    seems harmless enough.
    committed Jan 24, 2010
  3. Wrap mmap calls to help with portability.

    python2.4 in 'fink' on MacOS X seems to not like it when you pass a file
    length of 0, even though that's supposed to mean "determine map size
    automatically."
    committed Jan 24, 2010
  4. Makefile: build module using python distutils instead of manually.

    This makes it work with fink's version of python, among possibly other
    things.
    
    So now we can build chashsplit.so even on MacOS X tiger, even though tiger's
    python 2.3 is too old, by installing fink's python24 package first.
    committed Jan 24, 2010
  5. executable files: don't assume python2.5.

    The forcing of version 2.5 was leftover from before, when it was
    accidentally selecting python 2.4 by accident on some distros when both
    versions are installed.  But actually that's fine; bup works in python 2.4
    without problems.
    
    So let's not cause potentially *more* portability problems by forcing python
    2.5 when it might not exist.
    committed Jan 24, 2010
  6. Makefile: oops, all the $^ and $< were backwards.

    Not that it mattered, since all our files only had one dependency each.  But
    it causes confusion if you ever add extra ones.
    committed Jan 23, 2010
  7. Make README a symlink to README.md

    So as not to confuse anyone who has linked to the README file on github in
    the past.
    committed Jan 23, 2010
  8. Minor README format changes to make it markdown-compliant.

    That way it looks prettier on github.
    committed Jan 23, 2010
Commits on Jan 14, 2010
  1. @dcoombs

    Change t/tindex.py to pass on Mac OS.

    It turns out /etc is a symlink (to /private/etc) on Mac OS, so checking
    that the realpath of t/sampledata/etc is /etc fails.  Instead we now check
    against the realpath of /etc.
    dcoombs committed Jan 13, 2010
Commits on Jan 12, 2010
  1. Use a PackBitmap file as a quicker way to check .idx files.

    When we receive a new .idx file, we auto-generate a .map file from it.  It's
    essentially an allocation bitmap: for each 20-bit prefix, we assign one bit
    to tell us if that particular prefix is in that particular packfile.  If it
    isn't, there's no point searching the .idx file at all, so we can avoid
    mapping in a lot of pages.  If it is, though, we then have to search the
    .idx *too*, so we suffer a bit.
    
    On the whole this reduces memory thrashing quite a bit for me, though.
    Probably the number of bits needs to be variable in order to work over a
    wider range of packfile sizes/numbers.
    committed Jan 12, 2010
  2. memtest.py: a standalone program for testing memory usage in PackIndex.

    The majority of the memory usage in bup split/save is now caused by
    searching pack indexes for sha1 hashes.  The problem with this is that, in
    the common case for a first full backup, *none* of the object hashes will be
    found, so we'll *always* have to search *all* the packfiles.  With just 45
    packfiles of 200k objects each, that makes about (18-8)*45 = 450 binary
    search steps, or 100+ 4k pages that need to be loaded from disk, to check
    *each* object hash.  memtest.py lets us see how fast RSS creeps up under
    various conditions, and how different optimizations affect the result.
    committed Jan 11, 2010
  3. options parser: automatically convert strings to ints when appropriate.

    If the given parameter is exactly an int (ie. str(int(v)) == v) then convert
    it to an int automatically.  This helps avoid weird bugs in apps using the
    option parser.
    committed Jan 11, 2010
  4. cmd-save: if verbose==1, don't bother printing unmodified names.

    That just clutters the output; clearly what people *really* want to see is
    the list of files we're actually modifying.
    
    But if you want more, increase the verbosity and you'll get more.
    committed Jan 11, 2010
  5. client-server: only retrieve index files when actually needed.

    A busy server could end up with a *large* number of index files, mostly
    referring to objects from other clients.  Downloading all the indexes not only
    wastes bandwidth, but causes a more insidious problem: small servers end up
    having to mmap a huge number of large index files, which sucks lots of RAM.
    
    In general, the RAM on a server is roughly proportional to the disk space on
    that server.  So it's okay for larger clients to need more RAM in order
    to complete a backup.  However, it's not okay for the existence of larger
    clients to make smaller clients suffer.  Hopefully this change will settle
    it a bit.
    committed Jan 11, 2010
  6. Reduce default max objects per pack to 200,000 to save memory.

    After some testing, it seems each object sha1 we need to cache while writing
    a pack costs us about 83 bytes of memory.  (This isn't so great, so
    optimizing it in C later could cut this down a lot.)  The new limit of 200k
    objects takes about 16.6 megs of RAM, which nowadays is pretty acceptable.
    It also corresponds to roughly 1GB of packfile for my random select of
    sample data, so (since the default packfile limit is about 1GB anyway), this
    *mostly* won't matter.
    
    It will have an effect if your data is highly compressible, however; an
    8192-byte object could compress down to a very small size and you'd end up
    with a large number of objects.  The previous default limit of 10 million
    objects was ridiculous, since that would take 830 megs of RAM.
    committed Jan 11, 2010
  7. split_to_blob_or_tree was accidentally not using the 'fanout' setting.

    Thus, 'bup save' on huge files would suck lots of RAM.
    committed Jan 11, 2010
Commits on Jan 11, 2010
  1. Merge branch 'cygwin'

    * cygwin:
      Assorted cleanups to Luke's cygwin fixes.
      Makefile: work with cygwin on different windows versions.
      .gitignore sanity.
      Makefile:  On Windows, executable files must end with .exe.
      client.py:  Windows files don't support ':', so rename cachedir.
      index.py:  os.rename() fails on Windows if dstfile already exists.
      Don't try to rename tmpfiles into existing open files.
      helpers.py:  Cygwin doesn't support `hostname -f`, use `hostname`.
      cmd-index.py:  Retry os.open without O_LARGEFILE if not supported.
      Makefile:  Build on Windows under Cygwin.
    committed Jan 11, 2010
  2. Assorted cleanups to Luke's cygwin fixes.

    There were a few things that weren't quite done how I would have done them,
    so I changed the implementation.  Should still work in cygwin, though.
    
    The only actual functional changes are:
     - index.Reader.close() now actually sets m=None rather than just closing it
     - removed the "if rename fails, then unlink first" logic, which is
       seemingly not needed after all.
     - rather than special-casing cygwin to use "hostname" instead of "hostname
       -f", it turns out python has a socket.getfqdn() that does what we want.
    committed Jan 11, 2010
  3. Makefile: work with cygwin on different windows versions.

    Just check the CYGWIN part; don't depend on the fact that it's NT 5.1.  (Of
    course, uname isn't supposed to report such things by default anyway... but
    that's cygwin for you.)
    committed Jan 11, 2010
Commits on Jan 10, 2010
  1. @lkosewsk
  2. @lkosewsk

    .gitignore sanity.

    lkosewsk committed Jan 10, 2010
  3. @lkosewsk
  4. @lkosewsk

    client.py: Windows files don't support ':', so rename cachedir.

    Cachedir was previously $host:$dir, and is now $host-$dir.
    lkosewsk committed Jan 10, 2010
  5. @lkosewsk

    index.py: os.rename() fails on Windows if dstfile already exists.

    Hence, we perform an os.unlink on the dstfile if os.rename() receives
    an OSError exception, and try again.
    lkosewsk committed Jan 10, 2010
  6. @lkosewsk

    Don't try to rename tmpfiles into existing open files.

    Linux and friends have no problem with this, but Windows doesn't allow
    this without some effort, which we can avoid by... not needing to write
    to an already-open file.
    
    Give index.Reader a 'close' method which identifies and closes any open
    mmaped files, and make cmd-index.py use this before trying to close a
    index.Writer instance (which renames a tmpfile into the same file the
    Reader has mmaped).
    lkosewsk committed Jan 10, 2010
Something went wrong with that request. Please try again.